Skip to content

Commit 88a5045

Browse files
Evan Greenrafaeljw
authored andcommitted
PM: hibernate: Fix snapshot partial write lengths
snapshot_write() is inappropriately limiting the amount of data that can be written in cases where a partial page has already been written. For example, one would expect to be able to write 1 byte, then 4095 bytes to the snapshot device, and have both of those complete fully (since now we're aligned to a page again). But what ends up happening is we write 1 byte, then 4094/4095 bytes complete successfully. The reason is that simple_write_to_buffer()'s second argument is the total size of the buffer, not the size of the buffer minus the offset. Since simple_write_to_buffer() accounts for the offset in its implementation, snapshot_write() can just pass the full page size directly down. Signed-off-by: Evan Green <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent cefcf24 commit 88a5045

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/power/user.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ static ssize_t snapshot_write(struct file *filp, const char __user *buf,
177177
if (res <= 0)
178178
goto unlock;
179179
} else {
180-
res = PAGE_SIZE - pg_offp;
180+
res = PAGE_SIZE;
181181
}
182182

183183
if (!data_of(data->handle)) {

0 commit comments

Comments
 (0)