Skip to content

Commit 88ba976

Browse files
Jinjie Ruanvinodkoul
authored andcommitted
dmaengine: fsl-edma: Remove redundant dev_err() for platform_get_irq()
Since commit 7723f4c ("driver core: platform: Add an error message to platform_get_irq*()") and commit 2043727 ("driver core: platform: Make use of the helper function dev_err_probe()"), there is no need to call the dev_err() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Fixes: 72f5801 ("dmaengine: fsl-edma: integrate v3 support") Signed-off-by: Jinjie Ruan <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 74d8857 commit 88ba976

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/dma/fsl-edma-main.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,10 +230,8 @@ static int fsl_edma3_irq_init(struct platform_device *pdev, struct fsl_edma_engi
230230

231231
/* request channel irq */
232232
fsl_chan->txirq = platform_get_irq(pdev, i);
233-
if (fsl_chan->txirq < 0) {
234-
dev_err(&pdev->dev, "Can't get chan %d's irq.\n", i);
233+
if (fsl_chan->txirq < 0)
235234
return -EINVAL;
236-
}
237235

238236
ret = devm_request_irq(&pdev->dev, fsl_chan->txirq,
239237
fsl_edma3_tx_handler, IRQF_SHARED,

0 commit comments

Comments
 (0)