Skip to content

Commit 89388f8

Browse files
Yuuoniylinusw
authored andcommitted
pinctrl/rockchip: Add missing of_node_put() in rockchip_pinctrl_probe
The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. Fixes: 1e747e5 ("pinctrl: rockchip: base regmap supplied by a syscon") Fixes: 14dee86 ("pinctrl: rockchip: let pmu registers be supplied by a syscon") Signed-off-by: Miaoqian Lin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent c09ac19 commit 89388f8

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/pinctrl/pinctrl-rockchip.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2693,6 +2693,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
26932693
node = of_parse_phandle(np, "rockchip,grf", 0);
26942694
if (node) {
26952695
info->regmap_base = syscon_node_to_regmap(node);
2696+
of_node_put(node);
26962697
if (IS_ERR(info->regmap_base))
26972698
return PTR_ERR(info->regmap_base);
26982699
} else {
@@ -2725,6 +2726,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
27252726
node = of_parse_phandle(np, "rockchip,pmu", 0);
27262727
if (node) {
27272728
info->regmap_pmu = syscon_node_to_regmap(node);
2729+
of_node_put(node);
27282730
if (IS_ERR(info->regmap_pmu))
27292731
return PTR_ERR(info->regmap_pmu);
27302732
}

0 commit comments

Comments
 (0)