Skip to content

Commit 8939a3a

Browse files
cgxu519jankara
authored andcommitted
ext2: Fix i_op setting for special inode
Let's always set special inode i_op to &ext2_special_inode_operations regardless of CONFIG_EXT2_FS_XATTR setting. It makes sence to be able to query extended inode flags (needing ->setattr and ->getattr callbacks) even when CONFIG_EXT2_FS_XATTR is not set. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Chengguang Xu <[email protected]> Signed-off-by: Jan Kara <[email protected]>
1 parent 18bf340 commit 8939a3a

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

fs/ext2/namei.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,7 @@ static int ext2_mknod (struct inode * dir, struct dentry *dentry, umode_t mode,
136136
err = PTR_ERR(inode);
137137
if (!IS_ERR(inode)) {
138138
init_special_inode(inode, inode->i_mode, rdev);
139-
#ifdef CONFIG_EXT2_FS_XATTR
140139
inode->i_op = &ext2_special_inode_operations;
141-
#endif
142140
mark_inode_dirty(inode);
143141
err = ext2_add_nondir(dentry, inode);
144142
}

0 commit comments

Comments
 (0)