Skip to content

Commit 894d750

Browse files
marckleinebuddedavem330
authored andcommitted
net: netdev_queue: netdev_txq_completed_mb(): fix wake condition
netif_txq_try_stop() uses "get_desc >= start_thrs" as the check for the call to netif_tx_start_queue(). Use ">=" i netdev_txq_completed_mb(), too. Fixes: c91c46d ("net: provide macros for commonly copied lockless queue stop/wake code") Signed-off-by: Marc Kleine-Budde <[email protected]> Acked-by: Jakub Kicinski <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 9181d6f commit 894d750

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/net/netdev_queues.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ netdev_txq_completed_mb(struct netdev_queue *dev_queue,
128128
netdev_txq_completed_mb(txq, pkts, bytes); \
129129
\
130130
_res = -1; \
131-
if (pkts && likely(get_desc > start_thrs)) { \
131+
if (pkts && likely(get_desc >= start_thrs)) { \
132132
_res = 1; \
133133
if (unlikely(netif_tx_queue_stopped(txq)) && \
134134
!(down_cond)) { \

0 commit comments

Comments
 (0)