Skip to content

Commit 896066a

Browse files
harish-24mpe
authored andcommitted
selftests/powerpc: Fix build failure in ebb tests
We use OUTPUT directory as TMPOUT for checking no-pie option. Since commit f2f02eb ("kbuild: improve cc-option to clean up all temporary files") when building powerpc/ from selftests directory, the OUTPUT directory points to powerpc/pmu/ebb/ and gets removed when checking for -no-pie option in try-run routine, subsequently build fails with the following: $ make -C powerpc ... TARGET=ebb; BUILD_TARGET=$OUTPUT/$TARGET; mkdir -p $BUILD_TARGET; make OUTPUT=$BUILD_TARGET -k -C $TARGET all make[2]: Entering directory '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb' make[2]: *** No rule to make target 'Makefile'. make[2]: Failed to remake makefile 'Makefile'. make[2]: *** No rule to make target 'ebb.c', needed by '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb/reg_access_test'. make[2]: *** No rule to make target 'ebb_handler.S', needed by '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb/reg_access_test'. make[2]: *** No rule to make target 'trace.c', needed by '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb/reg_access_test'. make[2]: *** No rule to make target 'busy_loop.S', needed by '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb/reg_access_test'. make[2]: Target 'all' not remade because of errors. Fix this by adding a suffix to the OUTPUT directory so that the failure is avoided. Fixes: 9686813 ("selftests/powerpc: Fix try-run when source tree is not writable") Signed-off-by: Harish <[email protected]> [mpe: Mention that commit that triggered the breakage] Signed-off-by: Michael Ellerman <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent c1ed175 commit 896066a

File tree

1 file changed

+1
-1
lines changed
  • tools/testing/selftests/powerpc/pmu/ebb

1 file changed

+1
-1
lines changed

tools/testing/selftests/powerpc/pmu/ebb/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ noarg:
77
# The EBB handler is 64-bit code and everything links against it
88
CFLAGS += -m64
99

10-
TMPOUT = $(OUTPUT)/
10+
TMPOUT = $(OUTPUT)/TMPDIR/
1111
# Toolchains may build PIE by default which breaks the assembly
1212
no-pie-option := $(call try-run, echo 'int main() { return 0; }' | \
1313
$(CC) -Werror $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS) -no-pie -x c - -o "$$TMP", -no-pie)

0 commit comments

Comments
 (0)