Skip to content

Commit 89ee3ac

Browse files
rmurphy-armmmind
authored andcommitted
arm64: dts: rockchip: Fix Pinebook Pro FUSB302 interrupt
Although the FUSB302 driver has apparently supported the "fcs,int_n" property since the beginning, the DT binding has never documented it, and in fact defines a standard "interrupts" property as required. It's also questionable whether the GPIO specifier with GPIO_ACTIVE_HIGH is even correct, since the FUSB302 datasheet says INT_N is an "Active-LOW open-drain interrupt output", and the Pinebook Pro schematic shows it wired directly to the GPIO pin. Just use the standard property like all the other RK3399 boards sharing the same design. Signed-off-by: Robin Murphy <[email protected]> Link: https://lore.kernel.org/r/f731122c5ccde4e3d6d149a9d7bf01708b4279f7.1587736459.git.robin.murphy@arm.com Signed-off-by: Heiko Stuebner <[email protected]>
1 parent b14f389 commit 89ee3ac

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,8 @@
690690
fusb0: fusb30x@22 {
691691
compatible = "fcs,fusb302";
692692
reg = <0x22>;
693-
fcs,int_n = <&gpio1 RK_PA2 GPIO_ACTIVE_HIGH>;
693+
interrupt-parent = <&gpio1>;
694+
interrupts = <RK_PA2 IRQ_TYPE_LEVEL_LOW>;
694695
pinctrl-names = "default";
695696
pinctrl-0 = <&fusb0_int_gpio>;
696697
vbus-supply = <&vbus_typec>;

0 commit comments

Comments
 (0)