Skip to content

Commit 89fc548

Browse files
Sungjong Seonamjaejeon
authored andcommitted
exfat: fix potential deadlock on __exfat_get_dentry_set
When accessing a file with more entries than ES_MAX_ENTRY_NUM, the bh-array is allocated in __exfat_get_entry_set. The problem is that the bh-array is allocated with GFP_KERNEL. It does not make sense. In the following cases, a deadlock for sbi->s_lock between the two processes may occur. CPU0 CPU1 ---- ---- kswapd balance_pgdat lock(fs_reclaim) exfat_iterate lock(&sbi->s_lock) exfat_readdir exfat_get_uniname_from_ext_entry exfat_get_dentry_set __exfat_get_dentry_set kmalloc_array ... lock(fs_reclaim) ... evict exfat_evict_inode lock(&sbi->s_lock) To fix this, let's allocate bh-array with GFP_NOFS. Fixes: a3ff29a ("exfat: support dynamic allocate bh for exfat_entry_set_cache") Cc: [email protected] # v6.2+ Reported-by: [email protected] Closes: https://lore.kernel.org/lkml/[email protected] Signed-off-by: Sungjong Seo <[email protected]> Signed-off-by: Namjae Jeon <[email protected]>
1 parent 2248217 commit 89fc548

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/exfat/dir.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -813,7 +813,7 @@ static int __exfat_get_dentry_set(struct exfat_entry_set_cache *es,
813813

814814
num_bh = EXFAT_B_TO_BLK_ROUND_UP(off + num_entries * DENTRY_SIZE, sb);
815815
if (num_bh > ARRAY_SIZE(es->__bh)) {
816-
es->bh = kmalloc_array(num_bh, sizeof(*es->bh), GFP_KERNEL);
816+
es->bh = kmalloc_array(num_bh, sizeof(*es->bh), GFP_NOFS);
817817
if (!es->bh) {
818818
brelse(bh);
819819
return -ENOMEM;

0 commit comments

Comments
 (0)