Skip to content

Commit 8a44508

Browse files
committed
arm64: dts: rockchip: fix rk3399-puma gmac reset gpio
The puma gmac node currently uses opposite active-values for the gmac phy reset pin. The gpio-declaration uses active-high while the separate snps,reset-active-low property marks the pin as active low. While on the kernel side this works ok, other DT users may get confused - as seen with uboot right now. So bring this in line and make both properties match, similar to the other Rockchip board. Fixes: 2c66fc3 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM") Signed-off-by: Heiko Stuebner <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 7a7184f commit 8a44508

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@
157157
phy-mode = "rgmii";
158158
pinctrl-names = "default";
159159
pinctrl-0 = <&rgmii_pins>;
160-
snps,reset-gpio = <&gpio3 RK_PC0 GPIO_ACTIVE_HIGH>;
160+
snps,reset-gpio = <&gpio3 RK_PC0 GPIO_ACTIVE_LOW>;
161161
snps,reset-active-low;
162162
snps,reset-delays-us = <0 10000 50000>;
163163
tx_delay = <0x10>;

0 commit comments

Comments
 (0)