Skip to content

Commit 8aba27c

Browse files
Paolo Abenikuba-moo
authored andcommitted
igb: cope with large MAX_SKB_FRAGS
Sabrina reports that the igb driver does not cope well with large MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload corruption on TX. An easy reproducer is to run ssh to connect to the machine. With MAX_SKB_FRAGS=17 it works, with MAX_SKB_FRAGS=45 it fails. This has been reported originally in https://bugzilla.redhat.com/show_bug.cgi?id=2265320 The root cause of the issue is that the driver does not take into account properly the (possibly large) shared info size when selecting the ring layout, and will try to fit two packets inside the same 4K page even when the 1st fraglist will trump over the 2nd head. Address the issue by checking if 2K buffers are insufficient. Fixes: 3948b05 ("net: introduce a config option to tweak MAX_SKB_FRAGS") Reported-by: Jan Tluka <[email protected]> Reported-by: Jirka Hladky <[email protected]> Reported-by: Sabrina Dubroca <[email protected]> Tested-by: Sabrina Dubroca <[email protected]> Tested-by: Corinna Vinschen <[email protected]> Signed-off-by: Paolo Abeni <[email protected]> Signed-off-by: Corinna Vinschen <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 80a1e7b commit 8aba27c

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/net/ethernet/intel/igb/igb_main.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4808,6 +4808,7 @@ static void igb_set_rx_buffer_len(struct igb_adapter *adapter,
48084808

48094809
#if (PAGE_SIZE < 8192)
48104810
if (adapter->max_frame_size > IGB_MAX_FRAME_BUILD_SKB ||
4811+
IGB_2K_TOO_SMALL_WITH_PADDING ||
48114812
rd32(E1000_RCTL) & E1000_RCTL_SBP)
48124813
set_ring_uses_large_buffer(rx_ring);
48134814
#endif

0 commit comments

Comments
 (0)