Skip to content

Commit 8b77f23

Browse files
Christoph Hellwigaxboe
authored andcommitted
mpt3sas_scsih: don't set QUEUE_FLAG_NOMERGES
Setting QUEUE_FLAG_NOMERGES was added in commit d1b01d1 ("scsi: mpt3sas: Set NVMe device queue depth as 128") without any explanation. Drivers should second guess the block layer merge decisions, so remove the flag. Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Bart Van Assche <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent aa57abe commit 8b77f23

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/scsi/mpt3sas/mpt3sas_scsih.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2680,12 +2680,6 @@ scsih_device_configure(struct scsi_device *sdev, struct queue_limits *lim)
26802680
pcie_device_put(pcie_device);
26812681
spin_unlock_irqrestore(&ioc->pcie_device_lock, flags);
26822682
mpt3sas_scsih_change_queue_depth(sdev, qdepth);
2683-
/* Enable QUEUE_FLAG_NOMERGES flag, so that IOs won't be
2684-
** merged and can eliminate holes created during merging
2685-
** operation.
2686-
**/
2687-
blk_queue_flag_set(QUEUE_FLAG_NOMERGES,
2688-
sdev->request_queue);
26892683
lim->virt_boundary_mask = ioc->page_size - 1;
26902684
return 0;
26912685
}

0 commit comments

Comments
 (0)