Skip to content

Commit 8b97f99

Browse files
t-msngroeck
authored andcommitted
hwmon: (acpi_power_meter) Fix potential memory leak in acpi_power_meter_add()
Although it rarely happens, we should call free_capabilities() if error happens after read_capabilities() to free allocated strings. Fixes: de584af ("hwmon driver for ACPI 4.0 power meters") Signed-off-by: Misono Tomohiro <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]>
1 parent 016983d commit 8b97f99

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/hwmon/acpi_power_meter.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -883,7 +883,7 @@ static int acpi_power_meter_add(struct acpi_device *device)
883883

884884
res = setup_attrs(resource);
885885
if (res)
886-
goto exit_free;
886+
goto exit_free_capability;
887887

888888
resource->hwmon_dev = hwmon_device_register(&device->dev);
889889
if (IS_ERR(resource->hwmon_dev)) {
@@ -896,6 +896,8 @@ static int acpi_power_meter_add(struct acpi_device *device)
896896

897897
exit_remove:
898898
remove_attrs(resource);
899+
exit_free_capability:
900+
free_capabilities(resource);
899901
exit_free:
900902
kfree(resource);
901903
exit:

0 commit comments

Comments
 (0)