Skip to content

Commit 8c26c87

Browse files
committed
Merge tag 'sound-5.8-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound into master
Pull sound fixes from Takashi Iwai: "This became fairly large, containing mostly the collection of ASoC fixes that slipped from the previous request, so I sent now a bit earlier than usual. But all changes look small and mostly device-specific, hence nothing to worry too much. Majority of changes are for x86 based platforms and their CODEC drivers, in order to address some issues hit by their recent tests and fuzzing. The rest are other ASoC device-specific fixes (imx, qcom, wm8974, amd, rockchip) as well as a trivial fix for a kernel WARNING hit by syzkaller" * tag 'sound-5.8-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: (28 commits) ALSA: hda/realtek: Fixed ALC298 sound bug by adding quirk for Samsung Notebook Pen S ALSA: info: Drop WARN_ON() from buffer NULL sanity check ASoC: rt5682: Report the button event in the headset type only ASoC: Intel: bytcht_es8316: Add missed put_device() ASoC: rt5682: Enable Vref2 under using PLL2 ASoC: rt286: fix unexpected interrupt happens ASoC: wm8974: remove unsupported clock mode ASoC: wm8974: fix Boost Mixer Aux Switch ASoC: SOF: core: fix null-ptr-deref bug during device removal ASoc: codecs: max98373: remove Idle_bias_on to let codec suspend ASoC: codecs: max98373: Removed superfluous volume control from chip default ASoC: topology: fix tlvs in error handling for widget_dmixer ASoC: topology: fix kernel oops on route addition error ASoC: SOF: imx: add min/max channels for SAI/ESAI on i.MX8/i.MX8M ASoC: Intel: bdw-rt5677: fix non BE conversion ASoC: soc-dai: set dai_link dpcm_ flags with a helper MAINTAINERS: Add Shengjiu to reviewer list of sound/soc/fsl ASoC: core: Remove only the registered component in devm functions MAINTAINERS: Change Maintainer for some at91 drivers ASoC: dt-bindings: simple-card: Fix 'make dt_binding_check' warnings ...
2 parents 4fa640d + 568e4e8 commit 8c26c87

File tree

29 files changed

+266
-92
lines changed

29 files changed

+266
-92
lines changed

Documentation/devicetree/bindings/sound/simple-card.yaml

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -378,6 +378,8 @@ examples:
378378
- |
379379
sound {
380380
compatible = "simple-audio-card";
381+
#address-cells = <1>;
382+
#size-cells = <0>;
381383
382384
simple-audio-card,name = "rsnd-ak4643";
383385
simple-audio-card,format = "left_j";
@@ -391,10 +393,12 @@ examples:
391393
"ak4642 Playback", "DAI1 Playback";
392394
393395
dpcmcpu: simple-audio-card,cpu@0 {
396+
reg = <0>;
394397
sound-dai = <&rcar_sound 0>;
395398
};
396399
397400
simple-audio-card,cpu@1 {
401+
reg = <1>;
398402
sound-dai = <&rcar_sound 1>;
399403
};
400404
@@ -418,6 +422,8 @@ examples:
418422
- |
419423
sound {
420424
compatible = "simple-audio-card";
425+
#address-cells = <1>;
426+
#size-cells = <0>;
421427
422428
simple-audio-card,routing =
423429
"pcm3168a Playback", "DAI1 Playback",
@@ -426,6 +432,7 @@ examples:
426432
"pcm3168a Playback", "DAI4 Playback";
427433
428434
simple-audio-card,dai-link@0 {
435+
reg = <0>;
429436
format = "left_j";
430437
bitclock-master = <&sndcpu0>;
431438
frame-master = <&sndcpu0>;
@@ -439,22 +446,23 @@ examples:
439446
};
440447
441448
simple-audio-card,dai-link@1 {
449+
reg = <1>;
442450
format = "i2s";
443451
bitclock-master = <&sndcpu1>;
444452
frame-master = <&sndcpu1>;
445453
446454
convert-channels = <8>; /* TDM Split */
447455
448-
sndcpu1: cpu@0 {
456+
sndcpu1: cpu0 {
449457
sound-dai = <&rcar_sound 1>;
450458
};
451-
cpu@1 {
459+
cpu1 {
452460
sound-dai = <&rcar_sound 2>;
453461
};
454-
cpu@2 {
462+
cpu2 {
455463
sound-dai = <&rcar_sound 3>;
456464
};
457-
cpu@3 {
465+
cpu3 {
458466
sound-dai = <&rcar_sound 4>;
459467
};
460468
codec {
@@ -466,6 +474,7 @@ examples:
466474
};
467475
468476
simple-audio-card,dai-link@2 {
477+
reg = <2>;
469478
format = "i2s";
470479
bitclock-master = <&sndcpu2>;
471480
frame-master = <&sndcpu2>;

MAINTAINERS

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6956,6 +6956,7 @@ M: Timur Tabi <[email protected]>
69566956
M: Nicolin Chen <[email protected]>
69576957
M: Xiubo Li <[email protected]>
69586958
R: Fabio Estevam <[email protected]>
6959+
R: Shengjiu Wang <[email protected]>
69596960
L: [email protected] (moderated for non-subscribers)
69606961
69616962
S: Maintained
@@ -11333,17 +11334,17 @@ F: drivers/iio/adc/at91-sama5d2_adc.c
1133311334
F: include/dt-bindings/iio/adc/at91-sama5d2_adc.h
1133411335

1133511336
MICROCHIP SAMA5D2-COMPATIBLE SHUTDOWN CONTROLLER
11336-
M: Nicolas Ferre <nicolas.ferre@microchip.com>
11337+
M: Claudiu Beznea <claudiu.beznea@microchip.com>
1133711338
S: Supported
1133811339
F: drivers/power/reset/at91-sama5d2_shdwc.c
1133911340

1134011341
MICROCHIP SPI DRIVER
11341-
M: Nicolas Ferre <nicolas.ferre@microchip.com>
11342+
M: Tudor Ambarus <tudor.ambarus@microchip.com>
1134211343
S: Supported
1134311344
F: drivers/spi/spi-atmel.*
1134411345

1134511346
MICROCHIP SSC DRIVER
11346-
M: Nicolas Ferre <nicolas.ferre@microchip.com>
11347+
M: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
1134711348
L: [email protected] (moderated for non-subscribers)
1134811349
S: Supported
1134911350
F: drivers/misc/atmel-ssc.c

include/sound/rt5670.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ struct rt5670_platform_data {
1212
int jd_mode;
1313
bool in2_diff;
1414
bool dev_gpio;
15+
bool gpio1_is_ext_spk_en;
1516

1617
bool dmic_en;
1718
unsigned int dmic1_data_pin;

include/sound/soc-dai.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ void snd_soc_dai_resume(struct snd_soc_dai *dai);
161161
int snd_soc_dai_compress_new(struct snd_soc_dai *dai,
162162
struct snd_soc_pcm_runtime *rtd, int num);
163163
bool snd_soc_dai_stream_valid(struct snd_soc_dai *dai, int stream);
164+
void snd_soc_dai_link_set_capabilities(struct snd_soc_dai_link *dai_link);
164165
void snd_soc_dai_action(struct snd_soc_dai *dai,
165166
int stream, int action);
166167
static inline void snd_soc_dai_activate(struct snd_soc_dai *dai,

include/sound/soc.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -444,6 +444,8 @@ int devm_snd_soc_register_component(struct device *dev,
444444
const struct snd_soc_component_driver *component_driver,
445445
struct snd_soc_dai_driver *dai_drv, int num_dai);
446446
void snd_soc_unregister_component(struct device *dev);
447+
void snd_soc_unregister_component_by_driver(struct device *dev,
448+
const struct snd_soc_component_driver *component_driver);
447449
struct snd_soc_component *snd_soc_lookup_component_nolocked(struct device *dev,
448450
const char *driver_name);
449451
struct snd_soc_component *snd_soc_lookup_component(struct device *dev,

sound/core/info.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,9 @@ int snd_info_get_line(struct snd_info_buffer *buffer, char *line, int len)
606606
{
607607
int c;
608608

609-
if (snd_BUG_ON(!buffer || !buffer->buffer))
609+
if (snd_BUG_ON(!buffer))
610+
return 1;
611+
if (!buffer->buffer)
610612
return 1;
611613
if (len <= 0 || buffer->stop || buffer->error)
612614
return 1;

sound/pci/hda/patch_realtek.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7587,6 +7587,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
75877587
SND_PCI_QUIRK(0x144d, 0xc169, "Samsung Notebook 9 Pen (NP930SBE-K01US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
75887588
SND_PCI_QUIRK(0x144d, 0xc176, "Samsung Notebook 9 Pro (NP930MBE-K04US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
75897589
SND_PCI_QUIRK(0x144d, 0xc740, "Samsung Ativ book 8 (NP870Z5G)", ALC269_FIXUP_ATIV_BOOK_8),
7590+
SND_PCI_QUIRK(0x144d, 0xc812, "Samsung Notebook Pen S (NT950SBE-X58)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
75907591
SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC),
75917592
SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
75927593
SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),

sound/soc/amd/raven/pci-acp3x.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -232,9 +232,7 @@ static int snd_acp3x_probe(struct pci_dev *pci,
232232
}
233233
pm_runtime_set_autosuspend_delay(&pci->dev, 2000);
234234
pm_runtime_use_autosuspend(&pci->dev);
235-
pm_runtime_set_active(&pci->dev);
236235
pm_runtime_put_noidle(&pci->dev);
237-
pm_runtime_enable(&pci->dev);
238236
pm_runtime_allow(&pci->dev);
239237
return 0;
240238

@@ -303,7 +301,7 @@ static void snd_acp3x_remove(struct pci_dev *pci)
303301
ret = acp3x_deinit(adata->acp3x_base);
304302
if (ret)
305303
dev_err(&pci->dev, "ACP de-init failed\n");
306-
pm_runtime_disable(&pci->dev);
304+
pm_runtime_forbid(&pci->dev);
307305
pm_runtime_get_noresume(&pci->dev);
308306
pci_disable_msi(pci);
309307
pci_release_regions(pci);

sound/soc/codecs/max98373.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -779,13 +779,6 @@ static int max98373_probe(struct snd_soc_component *component)
779779
regmap_write(max98373->regmap,
780780
MAX98373_R202A_PCM_TO_SPK_MONO_MIX_2,
781781
0x1);
782-
/* Set inital volume (0dB) */
783-
regmap_write(max98373->regmap,
784-
MAX98373_R203D_AMP_DIG_VOL_CTRL,
785-
0x00);
786-
regmap_write(max98373->regmap,
787-
MAX98373_R203E_AMP_PATH_GAIN,
788-
0x00);
789782
/* Enable DC blocker */
790783
regmap_write(max98373->regmap,
791784
MAX98373_R203F_AMP_DSP_CFG,
@@ -869,7 +862,6 @@ static const struct snd_soc_component_driver soc_codec_dev_max98373 = {
869862
.num_dapm_widgets = ARRAY_SIZE(max98373_dapm_widgets),
870863
.dapm_routes = max98373_audio_map,
871864
.num_dapm_routes = ARRAY_SIZE(max98373_audio_map),
872-
.idle_bias_on = 1,
873865
.use_pmdown_time = 1,
874866
.endianness = 1,
875867
.non_legacy_dai_naming = 1,

sound/soc/codecs/rt286.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -272,13 +272,13 @@ static int rt286_jack_detect(struct rt286_priv *rt286, bool *hp, bool *mic)
272272
regmap_read(rt286->regmap, RT286_GET_MIC1_SENSE, &buf);
273273
*mic = buf & 0x80000000;
274274
}
275-
if (!*mic) {
275+
276+
if (!*hp) {
276277
snd_soc_dapm_disable_pin(dapm, "HV");
277278
snd_soc_dapm_disable_pin(dapm, "VREF");
278-
}
279-
if (!*hp)
280279
snd_soc_dapm_disable_pin(dapm, "LDO1");
281-
snd_soc_dapm_sync(dapm);
280+
snd_soc_dapm_sync(dapm);
281+
}
282282

283283
return 0;
284284
}

0 commit comments

Comments
 (0)