Skip to content

Commit 8c2b1b4

Browse files
committed
dt-bindings: can: mpfs: add missing required clock
The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a CAN bus clock. The bus clock was omitted when the binding was written, but is required for operation. Make up for lost time and add it. Cautionary tale in adding bindings without having implemented a real user for them perhaps. Fixes: c878d51 ("dt-bindings: can: mpfs: document the mpfs CAN controller") Reviewed-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Conor Dooley <[email protected]>
1 parent c886b72 commit 8c2b1b4

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ properties:
2424
maxItems: 1
2525

2626
clocks:
27-
maxItems: 1
27+
items:
28+
- description: AHB peripheral clock
29+
- description: CAN bus clock
2830

2931
required:
3032
- compatible
@@ -39,7 +41,7 @@ examples:
3941
can@2010c000 {
4042
compatible = "microchip,mpfs-can";
4143
reg = <0x2010c000 0x1000>;
42-
clocks = <&clkcfg 17>;
44+
clocks = <&clkcfg 17>, <&clkcfg 37>;
4345
interrupt-parent = <&plic>;
4446
interrupts = <56>;
4547
};

0 commit comments

Comments
 (0)