Skip to content

Commit 8c56bfe

Browse files
AnubhavS1acmel
authored andcommitted
perf trace: Set errpid to false for rseq and set_robust_list
The 'rseq' and 'set_robust_list' syscalls don't return a pid, so set errpid for both to false. Fixes: 0c1019e ("perf trace: Mark the 'rseq' arg in the rseq syscall as coming from user space") Fixes: 1de5b5d ("perf trace: Mark the 'head' arg in the set_robust_list syscall as coming from user space") Signed-off-by: Anubhav Shelat <[email protected]> Cc: Adrian Hunter <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Dapeng Mi <[email protected]> Cc: Ian Rogers <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: James Clark <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Kan Liang <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Michael Petlan <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Peter Zijlstra <[email protected]> Link: https://lore.kernel.org/r/[email protected] [ Remove explicit .errpid = false, omitting its initialization zeroes it, as noted by Namhyung ] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent 4d9b514 commit 8c56bfe

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/perf/builtin-trace.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1348,7 +1348,7 @@ static const struct syscall_fmt syscall_fmts[] = {
13481348
.arg = { [0] = { .scnprintf = SCA_FDAT, /* olddirfd */ },
13491349
[2] = { .scnprintf = SCA_FDAT, /* newdirfd */ },
13501350
[4] = { .scnprintf = SCA_RENAMEAT2_FLAGS, /* flags */ }, }, },
1351-
{ .name = "rseq", .errpid = true,
1351+
{ .name = "rseq",
13521352
.arg = { [0] = { .from_user = true /* rseq */, }, }, },
13531353
{ .name = "rt_sigaction",
13541354
.arg = { [0] = { .scnprintf = SCA_SIGNUM, /* sig */ }, }, },
@@ -1372,7 +1372,7 @@ static const struct syscall_fmt syscall_fmts[] = {
13721372
{ .name = "sendto",
13731373
.arg = { [3] = { .scnprintf = SCA_MSG_FLAGS, /* flags */ },
13741374
[4] = SCA_SOCKADDR_FROM_USER(addr), }, },
1375-
{ .name = "set_robust_list", .errpid = true,
1375+
{ .name = "set_robust_list",
13761376
.arg = { [0] = { .from_user = true /* head */, }, }, },
13771377
{ .name = "set_tid_address", .errpid = true, },
13781378
{ .name = "setitimer",

0 commit comments

Comments
 (0)