Skip to content

Commit 8d0caee

Browse files
Sergey Shtylyovstorulf
authored andcommitted
mmc: sdhci-spear: fix deferred probing
The driver overrides the error codes and IRQ0 returned by platform_get_irq() to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe permanently instead of the deferred probing. Switch to propagating the error codes upstream. Since commit ce753ad ("platform: finally disallow IRQ0 in platform_get_irq() and its ilk") IRQ0 is no longer returned by those APIs, so we now can safely ignore it... Fixes: 682798a ("mmc: sdhci-spear: Handle return value of platform_get_irq") Cc: [email protected] # v5.19+ Signed-off-by: Sergey Shtylyov <[email protected]> Acked-by: Viresh Kumar <[email protected]> Acked-by: Adrian Hunter <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Ulf Hansson <[email protected]>
1 parent b465dea commit 8d0caee

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/mmc/host/sdhci-spear.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ static int sdhci_probe(struct platform_device *pdev)
6565
host->hw_name = "sdhci";
6666
host->ops = &sdhci_pltfm_ops;
6767
host->irq = platform_get_irq(pdev, 0);
68-
if (host->irq <= 0) {
69-
ret = -EINVAL;
68+
if (host->irq < 0) {
69+
ret = host->irq;
7070
goto err_host;
7171
}
7272
host->quirks = SDHCI_QUIRK_BROKEN_ADMA;

0 commit comments

Comments
 (0)