Skip to content

Commit 8d2aeab

Browse files
Russell King (Oracle)Paolo Abeni
authored andcommitted
net: pcs: xpcs: remove switch() in xpcs_link_up_1000basex()
Remove an unnecessary switch() statement in xpcs_link_up_1000basex(). The only value this switch statement is interested in is SPEED_1000, all other values lead to an error. Replace this with a simple if() statement. Signed-off-by: Russell King (Oracle) <[email protected]> Tested-by: Serge Semin <[email protected]> Signed-off-by: Paolo Abeni <[email protected]>
1 parent 1d2709d commit 8d2aeab

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

drivers/net/pcs/pcs-xpcs.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1127,18 +1127,13 @@ static void xpcs_link_up_1000basex(struct dw_xpcs *xpcs, unsigned int neg_mode,
11271127
if (neg_mode == PHYLINK_PCS_NEG_INBAND_ENABLED)
11281128
return;
11291129

1130-
switch (speed) {
1131-
case SPEED_1000:
1132-
val = BMCR_SPEED1000;
1133-
break;
1134-
case SPEED_100:
1135-
case SPEED_10:
1136-
default:
1137-
dev_err(&xpcs->mdiodev->dev, "%s: speed = %d\n",
1130+
if (speed != SPEED_1000) {
1131+
dev_err(&xpcs->mdiodev->dev, "%s: speed %dMbps not supported\n",
11381132
__func__, speed);
11391133
return;
11401134
}
11411135

1136+
val = BMCR_SPEED1000;
11421137
if (duplex == DUPLEX_FULL)
11431138
val |= BMCR_FULLDPLX;
11441139
else

0 commit comments

Comments
 (0)