Skip to content

Commit 8d5d766

Browse files
cdleonardrafaeljw
authored andcommitted
soc: imx: gpc: Use GENPD_FLAG_RPM_ALWAYS_ON for ERR009619
This allows PU domain to be turned off in suspend and save power. Signed-off-by: Leonard Crestez <[email protected]> Reviewed-by: Ulf Hansson <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent ed61e18 commit 8d5d766

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

drivers/soc/imx/gpc.c

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -431,10 +431,19 @@ static int imx_gpc_probe(struct platform_device *pdev)
431431
return ret;
432432
}
433433

434-
/* Disable PU power down in normal operation if ERR009619 is present */
434+
/*
435+
* Disable PU power down by runtime PM if ERR009619 is present.
436+
*
437+
* The PRE clock will be paused for several cycles when turning on the
438+
* PU domain LDO from power down state. If PRE is in use at that time,
439+
* the IPU/PRG cannot get the correct display data from the PRE.
440+
*
441+
* This is not a concern when the whole system enters suspend state, so
442+
* it's safe to power down PU in this case.
443+
*/
435444
if (of_id_data->err009619_present)
436445
imx_gpc_domains[GPC_PGC_DOMAIN_PU].base.flags |=
437-
GENPD_FLAG_ALWAYS_ON;
446+
GENPD_FLAG_RPM_ALWAYS_ON;
438447

439448
/* Keep DISP always on if ERR006287 is present */
440449
if (of_id_data->err006287_present)

0 commit comments

Comments
 (0)