Skip to content

Commit 8ddb714

Browse files
committed
Revert "NFSD: Convert the callback workqueue to use delayed_work"
This commit was a pre-requisite for commit c1ccfcf ("NFSD: Reschedule CB operations when backchannel rpc_clnt is shut down"), which has already been reverted. Signed-off-by: Chuck Lever <[email protected]>
1 parent 9c8ecb9 commit 8ddb714

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

fs/nfsd/nfs4callback.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -983,7 +983,7 @@ static struct workqueue_struct *callback_wq;
983983
static bool nfsd4_queue_cb(struct nfsd4_callback *cb)
984984
{
985985
trace_nfsd_cb_queue(cb->cb_clp, cb);
986-
return queue_delayed_work(callback_wq, &cb->cb_work, 0);
986+
return queue_work(callback_wq, &cb->cb_work);
987987
}
988988

989989
static void nfsd41_cb_inflight_begin(struct nfs4_client *clp)
@@ -1482,7 +1482,7 @@ static void
14821482
nfsd4_run_cb_work(struct work_struct *work)
14831483
{
14841484
struct nfsd4_callback *cb =
1485-
container_of(work, struct nfsd4_callback, cb_work.work);
1485+
container_of(work, struct nfsd4_callback, cb_work);
14861486
struct nfs4_client *clp = cb->cb_clp;
14871487
struct rpc_clnt *clnt;
14881488
int flags;
@@ -1528,7 +1528,7 @@ void nfsd4_init_cb(struct nfsd4_callback *cb, struct nfs4_client *clp,
15281528
cb->cb_msg.rpc_argp = cb;
15291529
cb->cb_msg.rpc_resp = cb;
15301530
cb->cb_ops = ops;
1531-
INIT_DELAYED_WORK(&cb->cb_work, nfsd4_run_cb_work);
1531+
INIT_WORK(&cb->cb_work, nfsd4_run_cb_work);
15321532
cb->cb_status = 0;
15331533
cb->cb_need_restart = false;
15341534
cb->cb_holds_slot = false;

fs/nfsd/state.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ struct nfsd4_callback {
6868
struct nfs4_client *cb_clp;
6969
struct rpc_message cb_msg;
7070
const struct nfsd4_callback_ops *cb_ops;
71-
struct delayed_work cb_work;
71+
struct work_struct cb_work;
7272
int cb_seq_status;
7373
int cb_status;
7474
bool cb_need_restart;

0 commit comments

Comments
 (0)