NFSD: Initialize pointer ni with NULL and not plain integer 0

Colin Ian King · J. Bruce Fields · commit 8e70bf27fd20 · 2021-10-02T15:51:10.000-04:00
Pointer ni is being initialized with plain integer zero. Fix
this by initializing with NULL.

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: J. Bruce Fields &lt;bfields@redhat.com&gt;
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
@@ -1178,7 +1178,7 @@ extern void nfs_sb_deactive(struct super_block *sb);
 static __be32 nfsd4_ssc_setup_dul(struct nfsd_net *nn, char *ipaddr,
 		struct nfsd4_ssc_umount_item **retwork, struct vfsmount **ss_mnt)
 {
-	struct nfsd4_ssc_umount_item *ni = 0;
+	struct nfsd4_ssc_umount_item *ni = NULL;
 	struct nfsd4_ssc_umount_item *work = NULL;
 	struct nfsd4_ssc_umount_item *tmp;
 	DEFINE_WAIT(wait);
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
@@ -5531,7 +5531,7 @@ static void nfsd4_ssc_shutdown_umount(struct nfsd_net *nn)
 static void nfsd4_ssc_expire_umount(struct nfsd_net *nn)
 {
 	bool do_wakeup = false;
-	struct nfsd4_ssc_umount_item *ni = 0;
+	struct nfsd4_ssc_umount_item *ni = NULL;
 	struct nfsd4_ssc_umount_item *tmp;
 
 	spin_lock(&nn->nfsd_ssc_lock);

Original file line number	Diff line number	Diff line change
`@@ -1178,7 +1178,7 @@ extern void nfs_sb_deactive(struct super_block *sb);`
`1178`	`1178`	`static __be32 nfsd4_ssc_setup_dul(struct nfsd_net nn, char ipaddr,`
`1179`	`1179`	`struct nfsd4_ssc_umount_item retwork, struct vfsmount ss_mnt)`
`1180`	`1180`	`{`
`1181`		`- struct nfsd4_ssc_umount_item *ni = 0;`
	`1181`	`+ struct nfsd4_ssc_umount_item *ni = NULL;`
`1182`	`1182`	`struct nfsd4_ssc_umount_item *work = NULL;`
`1183`	`1183`	`struct nfsd4_ssc_umount_item *tmp;`
`1184`	`1184`	`DEFINE_WAIT(wait);`
Original file line number	Diff line number	Diff line change
`@@ -5531,7 +5531,7 @@ static void nfsd4_ssc_shutdown_umount(struct nfsd_net *nn)`
`5531`	`5531`	`static void nfsd4_ssc_expire_umount(struct nfsd_net *nn)`
`5532`	`5532`	`{`
`5533`	`5533`	`bool do_wakeup = false;`
`5534`		`- struct nfsd4_ssc_umount_item *ni = 0;`
	`5534`	`+ struct nfsd4_ssc_umount_item *ni = NULL;`
`5535`	`5535`	`struct nfsd4_ssc_umount_item *tmp;`
`5536`	`5536`
`5537`	`5537`	`spin_lock(&nn->nfsd_ssc_lock);`