HID: usbhid: remove redundant assignment to variable retval

Colin Ian King · Jiri Kosina · commit 8e9ddbde9ddb · 2020-06-16T17:16:44.000+02:00
The variable retval is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.cz&gt;
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
@@ -1672,7 +1672,7 @@ struct usb_interface *usbhid_find_interface(int minor)
 
 static int __init hid_init(void)
 {
-	int retval = -ENOMEM;
+	int retval;
 
 	retval = hid_quirks_init(quirks_param, BUS_USB, MAX_USBHID_BOOT_QUIRKS);
 	if (retval)

Original file line number	Diff line number	Diff line change
`@@ -1672,7 +1672,7 @@ struct usb_interface *usbhid_find_interface(int minor)`
`1672`	`1672`
`1673`	`1673`	`static int __init hid_init(void)`
`1674`	`1674`	`{`
`1675`		`- int retval = -ENOMEM;`
	`1675`	`+ int retval;`
`1676`	`1676`
`1677`	`1677`	`retval = hid_quirks_init(quirks_param, BUS_USB, MAX_USBHID_BOOT_QUIRKS);`
`1678`	`1678`	`if (retval)`