Skip to content

Commit 8e9f826

Browse files
andy-shevgregkh
authored andcommitted
serial: 8250_exar: Kill CTI_PCI_DEVICE()
The CTI_PCI_DEVICE() duplicates EXAR_DEVICE(). Kill the former. Signed-off-by: Andy Shevchenko <[email protected]> Tested-by: Parker Newman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 19234a5 commit 8e9f826

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

drivers/tty/serial/8250/8250_exar.c

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1737,7 +1737,6 @@ static const struct exar8250_board pbn_exar_XR17V8358 = {
17371737
.exit = pci_xr17v35x_exit,
17381738
};
17391739

1740-
// For Connect Tech cards with Exar vendor/device PCI IDs
17411740
#define CTI_EXAR_DEVICE(devid, bd) { \
17421741
PCI_DEVICE_SUB( \
17431742
PCI_VENDOR_ID_EXAR, \
@@ -1747,16 +1746,6 @@ static const struct exar8250_board pbn_exar_XR17V8358 = {
17471746
(kernel_ulong_t)&bd \
17481747
}
17491748

1750-
// For Connect Tech cards with Connect Tech vendor/device PCI IDs (FPGA based)
1751-
#define CTI_PCI_DEVICE(devid, bd) { \
1752-
PCI_DEVICE_SUB( \
1753-
PCI_VENDOR_ID_CONNECT_TECH, \
1754-
PCI_DEVICE_ID_CONNECT_TECH_PCI_##devid, \
1755-
PCI_ANY_ID, \
1756-
PCI_ANY_ID), 0, 0, \
1757-
(kernel_ulong_t)&bd \
1758-
}
1759-
17601749
#define EXAR_DEVICE(vend, devid, bd) { PCI_DEVICE_DATA(vend, devid, &bd) }
17611750

17621751
#define IBM_DEVICE(devid, sdevid, bd) { \
@@ -1786,6 +1775,7 @@ static const struct pci_device_id exar_pci_tbl[] = {
17861775
EXAR_DEVICE(ACCESSIO, COM_4SM, pbn_exar_XR17C15x),
17871776
EXAR_DEVICE(ACCESSIO, COM_8SM, pbn_exar_XR17C15x),
17881777

1778+
/* Connect Tech cards with Exar vendor/device PCI IDs */
17891779
CTI_EXAR_DEVICE(XR17C152, pbn_cti_xr17c15x),
17901780
CTI_EXAR_DEVICE(XR17C154, pbn_cti_xr17c15x),
17911781
CTI_EXAR_DEVICE(XR17C158, pbn_cti_xr17c15x),
@@ -1798,9 +1788,10 @@ static const struct pci_device_id exar_pci_tbl[] = {
17981788
CTI_EXAR_DEVICE(XR17V354, pbn_cti_xr17v35x),
17991789
CTI_EXAR_DEVICE(XR17V358, pbn_cti_xr17v35x),
18001790

1801-
CTI_PCI_DEVICE(XR79X_12_XIG00X, pbn_cti_fpga),
1802-
CTI_PCI_DEVICE(XR79X_12_XIG01X, pbn_cti_fpga),
1803-
CTI_PCI_DEVICE(XR79X_16, pbn_cti_fpga),
1791+
/* Connect Tech cards with Connect Tech vendor/device PCI IDs (FPGA based) */
1792+
EXAR_DEVICE(CONNECT_TECH, PCI_XR79X_12_XIG00X, pbn_cti_fpga),
1793+
EXAR_DEVICE(CONNECT_TECH, PCI_XR79X_12_XIG01X, pbn_cti_fpga),
1794+
EXAR_DEVICE(CONNECT_TECH, PCI_XR79X_16, pbn_cti_fpga),
18041795

18051796
IBM_DEVICE(XR17C152, SATURN_SERIAL_ONE_PORT, pbn_exar_ibm_saturn),
18061797

0 commit comments

Comments
 (0)