Skip to content

Commit 8ed1faf

Browse files
Jin Yaoacmel
authored andcommitted
perf pmu-events x86: Use CPU_CLK_UNHALTED.THREAD in Kernel_Utilization metric
The kernel utilization metric does multiplexing currently and is somewhat unreliable. The problem is that it uses two instances of the fixed counter, and the kernel has to multipleplex which causes errors. So should use CPU_CLK_UNHALTED.THREAD instead. Before: # perf stat -M Kernel_Utilization -- sleep 1 Performance counter stats for 'sleep 1': 1,419,425 cpu_clk_unhalted.ref_tsc:k <not counted> cpu_clk_unhalted.ref_tsc (0.00%) After: # perf stat -M Kernel_Utilization -- sleep 1 Performance counter stats for 'sleep 1': 746,688 cpu_clk_unhalted.thread:k # 0.7 Kernel_Utilization 1,088,348 cpu_clk_unhalted.thread Signed-off-by: Jin Yao <[email protected]> Reviewed-by: Andi Kleen <[email protected]> Reviewed-by: Kan Liang <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Jin Yao <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Peter Zijlstra <[email protected]> Link: http://lore.kernel.org/lkml/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent 47327f5 commit 8ed1faf

File tree

12 files changed

+12
-12
lines changed

12 files changed

+12
-12
lines changed

tools/perf/pmu-events/arch/x86/broadwell/bdw-metrics.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@
297297
},
298298
{
299299
"BriefDescription": "Fraction of cycles spent in Kernel mode",
300-
"MetricExpr": "CPU_CLK_UNHALTED.REF_TSC:k / CPU_CLK_UNHALTED.REF_TSC",
300+
"MetricExpr": "CPU_CLK_UNHALTED.THREAD:k / CPU_CLK_UNHALTED.THREAD",
301301
"MetricGroup": "Summary",
302302
"MetricName": "Kernel_Utilization"
303303
},

tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@
115115
},
116116
{
117117
"BriefDescription": "Fraction of cycles spent in Kernel mode",
118-
"MetricExpr": "CPU_CLK_UNHALTED.REF_TSC:k / CPU_CLK_UNHALTED.REF_TSC",
118+
"MetricExpr": "CPU_CLK_UNHALTED.THREAD:k / CPU_CLK_UNHALTED.THREAD",
119119
"MetricGroup": "Summary",
120120
"MetricName": "Kernel_Utilization"
121121
},

tools/perf/pmu-events/arch/x86/broadwellx/bdx-metrics.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@
297297
},
298298
{
299299
"BriefDescription": "Fraction of cycles spent in Kernel mode",
300-
"MetricExpr": "CPU_CLK_UNHALTED.REF_TSC:k / CPU_CLK_UNHALTED.REF_TSC",
300+
"MetricExpr": "CPU_CLK_UNHALTED.THREAD:k / CPU_CLK_UNHALTED.THREAD",
301301
"MetricGroup": "Summary",
302302
"MetricName": "Kernel_Utilization"
303303
},

tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@
316316
},
317317
{
318318
"BriefDescription": "Fraction of cycles spent in Kernel mode",
319-
"MetricExpr": "CPU_CLK_UNHALTED.REF_TSC:k / CPU_CLK_UNHALTED.REF_TSC",
319+
"MetricExpr": "CPU_CLK_UNHALTED.THREAD:k / CPU_CLK_UNHALTED.THREAD",
320320
"MetricGroup": "Summary",
321321
"MetricName": "Kernel_Utilization"
322322
},

tools/perf/pmu-events/arch/x86/haswell/hsw-metrics.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@
267267
},
268268
{
269269
"BriefDescription": "Fraction of cycles spent in Kernel mode",
270-
"MetricExpr": "CPU_CLK_UNHALTED.REF_TSC:k / CPU_CLK_UNHALTED.REF_TSC",
270+
"MetricExpr": "CPU_CLK_UNHALTED.THREAD:k / CPU_CLK_UNHALTED.THREAD",
271271
"MetricGroup": "Summary",
272272
"MetricName": "Kernel_Utilization"
273273
},

tools/perf/pmu-events/arch/x86/haswellx/hsx-metrics.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@
267267
},
268268
{
269269
"BriefDescription": "Fraction of cycles spent in Kernel mode",
270-
"MetricExpr": "CPU_CLK_UNHALTED.REF_TSC:k / CPU_CLK_UNHALTED.REF_TSC",
270+
"MetricExpr": "CPU_CLK_UNHALTED.THREAD:k / CPU_CLK_UNHALTED.THREAD",
271271
"MetricGroup": "Summary",
272272
"MetricName": "Kernel_Utilization"
273273
},

tools/perf/pmu-events/arch/x86/ivybridge/ivb-metrics.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@
285285
},
286286
{
287287
"BriefDescription": "Fraction of cycles spent in Kernel mode",
288-
"MetricExpr": "CPU_CLK_UNHALTED.REF_TSC:k / CPU_CLK_UNHALTED.REF_TSC",
288+
"MetricExpr": "CPU_CLK_UNHALTED.THREAD:k / CPU_CLK_UNHALTED.THREAD",
289289
"MetricGroup": "Summary",
290290
"MetricName": "Kernel_Utilization"
291291
},

tools/perf/pmu-events/arch/x86/ivytown/ivt-metrics.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@
285285
},
286286
{
287287
"BriefDescription": "Fraction of cycles spent in Kernel mode",
288-
"MetricExpr": "CPU_CLK_UNHALTED.REF_TSC:k / CPU_CLK_UNHALTED.REF_TSC",
288+
"MetricExpr": "CPU_CLK_UNHALTED.THREAD:k / CPU_CLK_UNHALTED.THREAD",
289289
"MetricGroup": "Summary",
290290
"MetricName": "Kernel_Utilization"
291291
},

tools/perf/pmu-events/arch/x86/jaketown/jkt-metrics.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@
171171
},
172172
{
173173
"BriefDescription": "Fraction of cycles spent in Kernel mode",
174-
"MetricExpr": "CPU_CLK_UNHALTED.REF_TSC:k / CPU_CLK_UNHALTED.REF_TSC",
174+
"MetricExpr": "CPU_CLK_UNHALTED.THREAD:k / CPU_CLK_UNHALTED.THREAD",
175175
"MetricGroup": "Summary",
176176
"MetricName": "Kernel_Utilization"
177177
},

tools/perf/pmu-events/arch/x86/sandybridge/snb-metrics.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@
171171
},
172172
{
173173
"BriefDescription": "Fraction of cycles spent in Kernel mode",
174-
"MetricExpr": "CPU_CLK_UNHALTED.REF_TSC:k / CPU_CLK_UNHALTED.REF_TSC",
174+
"MetricExpr": "CPU_CLK_UNHALTED.THREAD:k / CPU_CLK_UNHALTED.THREAD",
175175
"MetricGroup": "Summary",
176176
"MetricName": "Kernel_Utilization"
177177
},

0 commit comments

Comments
 (0)