Skip to content

Commit 8f0c01e

Browse files
necipfazilandy-shev
authored andcommitted
platform/x86: fix kconfig dependency warning for LG_LAPTOP
When LG_LAPTOP is enabled and NEW_LEDS is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for LEDS_CLASS Depends on [n]: NEW_LEDS [=n] Selected by [y]: - LG_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && ACPI_WMI [=y] && INPUT [=y] The reason is that LG_LAPTOP selects LEDS_CLASS without depending on or selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS. Honor the kconfig menu hierarchy to remove kconfig dependency warnings. Fixes: dbf0c5a ("platform/x86: Add LG Gram laptop special features driver") Signed-off-by: Necip Fazil Yildiran <[email protected]> Reviewed-by: Hans de Goede <[email protected]> Acked-by: mark gross <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
1 parent 5f38b06 commit 8f0c01e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/platform/x86/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1112,6 +1112,7 @@ config LG_LAPTOP
11121112
depends on ACPI_WMI
11131113
depends on INPUT
11141114
select INPUT_SPARSEKMAP
1115+
select NEW_LEDS
11151116
select LEDS_CLASS
11161117
help
11171118
This driver adds support for hotkeys as well as control of keyboard

0 commit comments

Comments
 (0)