Skip to content

Commit 8f0e859

Browse files
arndbrafaeljw
authored andcommitted
ACPI: NFIT: Add declaration in a local header
The nfit_intel_shutdown_status() function has a __weak defintion in nfit.c and an override in acpi_nfit_test.c for testing purposes. This works without an extern declaration, but causes a W=1 build warning: drivers/acpi/nfit/core.c:1717:13: error: no previous prototype for 'nfit_intel_shutdown_status' [-Werror=missing-prototypes] Add a declaration in a header that gets included from both sides to shut up the warning and ensure that the prototypes actually match. Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Dave Jiang <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 9561de3 commit 8f0e859

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/acpi/nfit/nfit.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,4 +347,6 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm,
347347
void acpi_nfit_desc_init(struct acpi_nfit_desc *acpi_desc, struct device *dev);
348348
bool intel_fwa_supported(struct nvdimm_bus *nvdimm_bus);
349349
extern struct device_attribute dev_attr_firmware_activate_noidle;
350+
void nfit_intel_shutdown_status(struct nfit_mem *nfit_mem);
351+
350352
#endif /* __NFIT_H__ */

0 commit comments

Comments
 (0)