Skip to content

Commit 8fa052c

Browse files
uditkumartimathieupoirier
authored andcommitted
remoteproc: k3-r5: Delay notification of wakeup event
Few times, core1 was scheduled to boot first before core0, which leads to error: 'k3_r5_rproc_start: can not start core 1 before core 0'. This was happening due to some scheduling between prepare and start callback. The probe function waits for event, which is getting triggered by prepare callback. To avoid above condition move event trigger to start instead of prepare callback. Fixes: 61f6f68 ("remoteproc: k3-r5: Wait for core0 power-up before powering up core1") Signed-off-by: Udit Kumar <[email protected]> [ Applied wakeup event trigger only for Split-Mode booted rprocs ] Signed-off-by: Beleswar Padhi <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mathieu Poirier <[email protected]>
1 parent ebcf900 commit 8fa052c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/remoteproc/ti_k3_r5_remoteproc.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -469,8 +469,6 @@ static int k3_r5_rproc_prepare(struct rproc *rproc)
469469
ret);
470470
return ret;
471471
}
472-
core->released_from_reset = true;
473-
wake_up_interruptible(&cluster->core_transition);
474472

475473
/*
476474
* Newer IP revisions like on J7200 SoCs support h/w auto-initialization
@@ -587,6 +585,9 @@ static int k3_r5_rproc_start(struct rproc *rproc)
587585
ret = k3_r5_core_run(core);
588586
if (ret)
589587
return ret;
588+
589+
core->released_from_reset = true;
590+
wake_up_interruptible(&cluster->core_transition);
590591
}
591592

592593
return 0;

0 commit comments

Comments
 (0)