Skip to content

Commit 8ffade7

Browse files
ziweixiaokuba-moo
authored andcommitted
gve: Flow steering trigger reset only for timeout error
When configuring flow steering rules, the driver is currently going through a reset for all errors from the device. Instead, the driver should only reset when there's a timeout error from the device. Fixes: 57718b6 ("gve: Add flow steering adminq commands") Cc: [email protected] Signed-off-by: Ziwei Xiao <[email protected]> Signed-off-by: Jeroen de Borst <[email protected]> Reviewed-by: Harshitha Ramamurthy <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 41ffcd9 commit 8ffade7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/ethernet/google/gve/gve_adminq.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1248,10 +1248,10 @@ gve_adminq_configure_flow_rule(struct gve_priv *priv,
12481248
sizeof(struct gve_adminq_configure_flow_rule),
12491249
flow_rule_cmd);
12501250

1251-
if (err) {
1251+
if (err == -ETIME) {
12521252
dev_err(&priv->pdev->dev, "Timeout to configure the flow rule, trigger reset");
12531253
gve_reset(priv, true);
1254-
} else {
1254+
} else if (!err) {
12551255
priv->flow_rules_cache.rules_cache_synced = false;
12561256
}
12571257

0 commit comments

Comments
 (0)