Skip to content

Commit 9055d87

Browse files
nxpfrankliShawn Guo
authored andcommitted
arm64: dts: imx8-ss-dma: fix pwm lpcg indices
adma_pwm_lpcg: clock-controller@5a590000 { ... col1 col2 clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>,// 0 0 <&dma_ipg_clk>; // 1 4 clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>; ... }; Col1: index, which existing dts try to get. Col2: actual index in lpcg driver. adma_pwm: pwm@5a190000 { ... clocks = <&adma_pwm_lpcg 1>, <&adma_pwm_lpcg 0>; ^^ ^^ Should be clocks = <&adma_pwm_lpcg IMX_LPCG_CLK_4>, <&adma_pwm_lpcg IMX_LPCG_CLK_0>; }; Arg0 will be divided by 4 in lcpg driver, so pwm will get IMX_SC_PM_CLK_PER by <&adma_pwm_lpcg 1>, <&adma_pwm_lpcg 0>. Although function can work, code logic is wrong. Fix it by use correct indices. Cc: [email protected] Fixes: f1d6a6b ("arm64: dts: imx8qxp: add adma_pwm in adma") Signed-off-by: Frank Li <[email protected]> Signed-off-by: Shawn Guo <[email protected]>
1 parent f72b544 commit 9055d87

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,8 @@ dma_subsys: bus@5a000000 {
145145
compatible = "fsl,imx8qxp-pwm", "fsl,imx27-pwm";
146146
reg = <0x5a190000 0x1000>;
147147
interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
148-
clocks = <&adma_pwm_lpcg 1>,
149-
<&adma_pwm_lpcg 0>;
148+
clocks = <&adma_pwm_lpcg IMX_LPCG_CLK_4>,
149+
<&adma_pwm_lpcg IMX_LPCG_CLK_0>;
150150
clock-names = "ipg", "per";
151151
assigned-clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>;
152152
assigned-clock-rates = <24000000>;

0 commit comments

Comments
 (0)