Skip to content

Commit 90670fd

Browse files
kv2019itiwai
authored andcommitted
ALSA: hda/hdmi: improve debug traces for stream lookups
The HDMI codec driver has two debug traces printed from different functions but with identical message content: "HDMI: hinfo 000000006a6b84d9 not registered" Fix this duplication and also add a bit more context in addition to raw object pointer, to help analysis of kernel logs. Reviewed-by: Ranjani Sridharan <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]> Signed-off-by: Kai Vehmanen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 5627503 commit 90670fd

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

sound/pci/hda/patch_hdmi.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ static int hinfo_to_pcm_index(struct hda_codec *codec,
259259
if (get_pcm_rec(spec, pcm_idx)->stream == hinfo)
260260
return pcm_idx;
261261

262-
codec_warn(codec, "HDMI: hinfo %p not registered\n", hinfo);
262+
codec_warn(codec, "HDMI: hinfo %p not tied to a PCM\n", hinfo);
263263
return -EINVAL;
264264
}
265265

@@ -277,7 +277,8 @@ static int hinfo_to_pin_index(struct hda_codec *codec,
277277
return pin_idx;
278278
}
279279

280-
codec_dbg(codec, "HDMI: hinfo %p not registered\n", hinfo);
280+
codec_dbg(codec, "HDMI: hinfo %p (pcm %d) not registered\n", hinfo,
281+
hinfo_to_pcm_index(codec, hinfo));
281282
return -EINVAL;
282283
}
283284

0 commit comments

Comments
 (0)