Skip to content

Commit 90751fb

Browse files
larsclausenjic23
authored andcommitted
iio: dln2: Check return value of devm_iio_trigger_register()
Registering a trigger can fail and the return value of devm_iio_trigger_register() must be checked. Otherwise undefined behavior can occur when the trigger is used. Fixes: 7c0299e ("iio: adc: Add support for DLN2 ADC") Signed-off-by: Lars-Peter Clausen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Cc: <[email protected]> Signed-off-by: Jonathan Cameron <[email protected]>
1 parent a827a49 commit 90751fb

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

drivers/iio/adc/dln2-adc.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,11 @@ static int dln2_adc_probe(struct platform_device *pdev)
655655
return -ENOMEM;
656656
}
657657
iio_trigger_set_drvdata(dln2->trig, dln2);
658-
devm_iio_trigger_register(dev, dln2->trig);
658+
ret = devm_iio_trigger_register(dev, dln2->trig);
659+
if (ret) {
660+
dev_err(dev, "failed to register trigger: %d\n", ret);
661+
return ret;
662+
}
659663
iio_trigger_set_immutable(indio_dev, dln2->trig);
660664

661665
ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,

0 commit comments

Comments
 (0)