Skip to content

Commit 90c45fc

Browse files
Uwe Kleine-Königsravnborg
authored andcommitted
drm/panel: s6e63m0: Make s6e63m0_remove() return void
Up to now s6e63m0_remove() returns zero unconditionally. Make it return void instead which makes it easier to see in the callers that there is no error to handle. Also the return value of spi remove callbacks is ignored anyway. Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Sam Ravnborg <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 5e51cc0 commit 90c45fc

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

drivers/gpu/drm/panel/panel-samsung-s6e63m0-dsi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,8 @@ static int s6e63m0_dsi_probe(struct mipi_dsi_device *dsi)
116116
static int s6e63m0_dsi_remove(struct mipi_dsi_device *dsi)
117117
{
118118
mipi_dsi_detach(dsi);
119-
return s6e63m0_remove(&dsi->dev);
119+
s6e63m0_remove(&dsi->dev);
120+
return 0;
120121
}
121122

122123
static const struct of_device_id s6e63m0_dsi_of_match[] = {

drivers/gpu/drm/panel/panel-samsung-s6e63m0-spi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@ static int s6e63m0_spi_probe(struct spi_device *spi)
6464

6565
static int s6e63m0_spi_remove(struct spi_device *spi)
6666
{
67-
return s6e63m0_remove(&spi->dev);
67+
s6e63m0_remove(&spi->dev);
68+
return 0;
6869
}
6970

7071
static const struct of_device_id s6e63m0_spi_of_match[] = {

drivers/gpu/drm/panel/panel-samsung-s6e63m0.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -749,13 +749,11 @@ int s6e63m0_probe(struct device *dev, void *trsp,
749749
}
750750
EXPORT_SYMBOL_GPL(s6e63m0_probe);
751751

752-
int s6e63m0_remove(struct device *dev)
752+
void s6e63m0_remove(struct device *dev)
753753
{
754754
struct s6e63m0 *ctx = dev_get_drvdata(dev);
755755

756756
drm_panel_remove(&ctx->panel);
757-
758-
return 0;
759757
}
760758
EXPORT_SYMBOL_GPL(s6e63m0_remove);
761759

drivers/gpu/drm/panel/panel-samsung-s6e63m0.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,6 @@ int s6e63m0_probe(struct device *dev, void *trsp,
3535
const u8 *data,
3636
size_t len),
3737
bool dsi_mode);
38-
int s6e63m0_remove(struct device *dev);
38+
void s6e63m0_remove(struct device *dev);
3939

4040
#endif /* _PANEL_SAMSUNG_S6E63M0_H */

0 commit comments

Comments
 (0)