Skip to content

Commit 90fe70d

Browse files
ilkka-koskinennamhyung
authored andcommitted
perf vendor events arm64: AmpereOne: Add missing DefaultMetricgroupName fields
AmpereOne metrics were missing DefaultMetricgroupName from metrics with "Default" in group name resulting perf to segfault. Add the missing field to address the issue. Fixes: 59faeaf ("perf vendor events arm64: Fix for AmpereOne metrics") Signed-off-by: Ilkka Koskinen <[email protected]> Reviewed-by: Ian Rogers <[email protected]> Cc: James Clark <[email protected]> Cc: Will Deacon <[email protected]> Cc: Leo Yan <[email protected]> Cc: Mike Leach <[email protected]> Cc: John Garry <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Namhyung Kim <[email protected]>
1 parent e2b005d commit 90fe70d

File tree

1 file changed

+2
-0
lines changed
  • tools/perf/pmu-events/arch/arm64/ampere/ampereone

1 file changed

+2
-0
lines changed

tools/perf/pmu-events/arch/arm64/ampere/ampereone/metrics.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,13 +231,15 @@
231231
"MetricName": "slots_lost_misspeculation_fraction",
232232
"MetricExpr": "100 * ((OP_SPEC - OP_RETIRED) / (CPU_CYCLES * #slots))",
233233
"BriefDescription": "Fraction of slots lost due to misspeculation",
234+
"DefaultMetricgroupName": "TopdownL1",
234235
"MetricGroup": "Default;TopdownL1",
235236
"ScaleUnit": "1percent of slots"
236237
},
237238
{
238239
"MetricName": "retired_fraction",
239240
"MetricExpr": "100 * (OP_RETIRED / (CPU_CYCLES * #slots))",
240241
"BriefDescription": "Fraction of slots retiring, useful work",
242+
"DefaultMetricgroupName": "TopdownL1",
241243
"MetricGroup": "Default;TopdownL1",
242244
"ScaleUnit": "1percent of slots"
243245
},

0 commit comments

Comments
 (0)