Skip to content

Commit 9103703

Browse files
Henry Martinkuba-moo
authored andcommitted
net/mlx5: Fix null-ptr-deref in mlx5_create_{inner_,}ttc_table()
Add NULL check for mlx5_get_flow_namespace() returns in mlx5_create_inner_ttc_table() and mlx5_create_ttc_table() to prevent NULL pointer dereference. Fixes: 137f3d5 ("net/mlx5: Support matching on l4_type for ttc_table") Signed-off-by: Henry Martin <[email protected]> Reviewed-by: Mark Bloch <[email protected]> Reviewed-by: Michal Swiatkowski <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 750d0ac commit 9103703

File tree

1 file changed

+10
-0
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core/lib

1 file changed

+10
-0
lines changed

drivers/net/ethernet/mellanox/mlx5/core/lib/fs_ttc.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -655,6 +655,11 @@ struct mlx5_ttc_table *mlx5_create_inner_ttc_table(struct mlx5_core_dev *dev,
655655
}
656656

657657
ns = mlx5_get_flow_namespace(dev, params->ns_type);
658+
if (!ns) {
659+
kvfree(ttc);
660+
return ERR_PTR(-EOPNOTSUPP);
661+
}
662+
658663
groups = use_l4_type ? &inner_ttc_groups[TTC_GROUPS_USE_L4_TYPE] :
659664
&inner_ttc_groups[TTC_GROUPS_DEFAULT];
660665

@@ -728,6 +733,11 @@ struct mlx5_ttc_table *mlx5_create_ttc_table(struct mlx5_core_dev *dev,
728733
}
729734

730735
ns = mlx5_get_flow_namespace(dev, params->ns_type);
736+
if (!ns) {
737+
kvfree(ttc);
738+
return ERR_PTR(-EOPNOTSUPP);
739+
}
740+
731741
groups = use_l4_type ? &ttc_groups[TTC_GROUPS_USE_L4_TYPE] :
732742
&ttc_groups[TTC_GROUPS_DEFAULT];
733743

0 commit comments

Comments
 (0)