Skip to content

Commit 914ee6e

Browse files
author
Thomas Zimmermann
committed
drm/appletbdrm: Fix ref-counting on dmadev
Remove the put_device() call on dmadev. The driver sets the field without getting a reference, so it shouldn't put a reference either. The dmadev field points to the regular USB device for which DRM maintains a reference internally. Hence dmadev will not become dangling during the DRM device's lifetime. Signed-off-by: Thomas Zimmermann <[email protected]> Fixes: 0670c2f ("drm/tiny: add driver for Apple Touch Bars in x86 Macs") Cc: Aditya Garg <[email protected]> Cc: Aun-Ali Zaidi <[email protected]> Cc: [email protected] Acked-by: Aditya Garg <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent d65a27f commit 914ee6e

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/gpu/drm/tiny/appletbdrm.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -805,7 +805,6 @@ static void appletbdrm_disconnect(struct usb_interface *intf)
805805
struct appletbdrm_device *adev = usb_get_intfdata(intf);
806806
struct drm_device *drm = &adev->drm;
807807

808-
put_device(adev->dmadev);
809808
drm_dev_unplug(drm);
810809
drm_atomic_helper_shutdown(drm);
811810
}

0 commit comments

Comments
 (0)