Skip to content

Commit 91502a9

Browse files
sergeev917tiwai
authored andcommitted
ALSA: hda/realtek: fix speakers and micmute on HP 855 G8
There are several PCI ids associated with HP EliteBook 855 G8 Notebook PC. Commit 0e68c4b ("ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8") covers 0x103c:0x8896, while this commit covers 0x103c:0x8895 which needs some additional work on top of the quirk from 0e68c4b. Note that the device can boot up with working speakers and micmute LED without this patch, but the success rate would be quite low (order of 16 working boots across 709 boots) at least for the built-in drivers scenario. This also means that there are some timing issues during early boot and this patch is a workaround. With this patch applied speakers and headphones are consistenly working, as well as mute/micmute LEDs and the internal microphone. Signed-off-by: Alexander Sergeyev <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 081c737 commit 91502a9

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

sound/pci/hda/patch_realtek.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6948,6 +6948,7 @@ enum {
69486948
ALC285_FIXUP_LEGION_Y9000X_AUTOMUTE,
69496949
ALC287_FIXUP_LEGION_16ACHG6,
69506950
ALC287_FIXUP_CS35L41_I2C_2,
6951+
ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED,
69516952
};
69526953

69536954
static const struct hda_fixup alc269_fixups[] = {
@@ -8698,6 +8699,16 @@ static const struct hda_fixup alc269_fixups[] = {
86988699
.type = HDA_FIXUP_FUNC,
86998700
.v.func = cs35l41_fixup_i2c_two,
87008701
},
8702+
[ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED] = {
8703+
.type = HDA_FIXUP_VERBS,
8704+
.v.verbs = (const struct hda_verb[]) {
8705+
{ 0x20, AC_VERB_SET_COEF_INDEX, 0x19 },
8706+
{ 0x20, AC_VERB_SET_PROC_COEF, 0x8e11 },
8707+
{ }
8708+
},
8709+
.chained = true,
8710+
.chain_id = ALC285_FIXUP_HP_MUTE_LED,
8711+
},
87018712
};
87028713

87038714
static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -8911,6 +8922,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
89118922
SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
89128923
SND_PCI_QUIRK(0x103c, 0x8873, "HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
89138924
SND_PCI_QUIRK(0x103c, 0x888d, "HP ZBook Power 15.6 inch G8 Mobile Workstation PC", ALC236_FIXUP_HP_GPIO_LED),
8925+
SND_PCI_QUIRK(0x103c, 0x8895, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED),
89148926
SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED),
89158927
SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
89168928
SND_PCI_QUIRK(0x103c, 0x88d0, "HP Pavilion 15-eh1xxx (mainboard 88D0)", ALC287_FIXUP_HP_GPIO_LED),

0 commit comments

Comments
 (0)