Skip to content

Commit 91d3ff9

Browse files
sravnborgandreas-gaisler
authored andcommitted
sparc32: Fix parport build with sparc32
include/asm/parport.h is sparc64 specific. Rename it to parport_64.h and use the generic version for sparc32. This fixed all{mod,yes}config build errors like: parport_pc.c:(.text):undefined-reference-to-ebus_dma_enable parport_pc.c:(.text):undefined-reference-to-ebus_dma_irq_enable parport_pc.c:(.text):undefined-reference-to-ebus_dma_register The errors occur as the sparc32 build references sparc64 symbols. Signed-off-by: Sam Ravnborg <[email protected]> Cc: "David S. Miller" <[email protected]> Cc: Andreas Larsson <[email protected]> Cc: Randy Dunlap <[email protected]> Cc: Maciej W. Rozycki <[email protected]> Closes: https://lore.kernel.org/r/[email protected]/ Fixes: 66bcd06 ("parport_pc: Also enable driver for PCI systems") Cc: [email protected] # v5.18+ Tested-by: Randy Dunlap <[email protected]> # build-tested Reviewed-by: Andreas Larsson <[email protected]> Signed-off-by: Andreas Larsson <[email protected]> Link: https://lore.kernel.org/r/20240224-sam-fix-sparc32-all-builds-v2-6-1f186603c5c4@ravnborg.org
1 parent 99bd9a4 commit 91d3ff9

File tree

2 files changed

+263
-252
lines changed

2 files changed

+263
-252
lines changed

arch/sparc/include/asm/parport.h

Lines changed: 7 additions & 252 deletions
Original file line numberDiff line numberDiff line change
@@ -1,256 +1,11 @@
11
/* SPDX-License-Identifier: GPL-2.0 */
2-
/* parport.h: sparc64 specific parport initialization and dma.
3-
*
4-
* Copyright (C) 1999 Eddie C. Dost ([email protected])
5-
*/
2+
#ifndef ___ASM_SPARC_PARPORT_H
3+
#define ___ASM_SPARC_PARPORT_H
64

7-
#ifndef _ASM_SPARC64_PARPORT_H
8-
#define _ASM_SPARC64_PARPORT_H 1
9-
10-
#include <linux/of.h>
11-
#include <linux/platform_device.h>
12-
13-
#include <asm/ebus_dma.h>
14-
#include <asm/ns87303.h>
15-
#include <asm/prom.h>
16-
17-
#define PARPORT_PC_MAX_PORTS PARPORT_MAX
18-
19-
/*
20-
* While sparc64 doesn't have an ISA DMA API, we provide something that looks
21-
* close enough to make parport_pc happy
22-
*/
23-
#define HAS_DMA
24-
25-
#ifdef CONFIG_PARPORT_PC_FIFO
26-
static DEFINE_SPINLOCK(dma_spin_lock);
27-
28-
#define claim_dma_lock() \
29-
({ unsigned long flags; \
30-
spin_lock_irqsave(&dma_spin_lock, flags); \
31-
flags; \
32-
})
33-
34-
#define release_dma_lock(__flags) \
35-
spin_unlock_irqrestore(&dma_spin_lock, __flags);
5+
#if defined(__sparc__) && defined(__arch64__)
6+
#include <asm/parport_64.h>
7+
#else
8+
#include <asm-generic/parport.h>
9+
#endif
3610
#endif
3711

38-
static struct sparc_ebus_info {
39-
struct ebus_dma_info info;
40-
unsigned int addr;
41-
unsigned int count;
42-
int lock;
43-
44-
struct parport *port;
45-
} sparc_ebus_dmas[PARPORT_PC_MAX_PORTS];
46-
47-
static DECLARE_BITMAP(dma_slot_map, PARPORT_PC_MAX_PORTS);
48-
49-
static inline int request_dma(unsigned int dmanr, const char *device_id)
50-
{
51-
if (dmanr >= PARPORT_PC_MAX_PORTS)
52-
return -EINVAL;
53-
if (xchg(&sparc_ebus_dmas[dmanr].lock, 1) != 0)
54-
return -EBUSY;
55-
return 0;
56-
}
57-
58-
static inline void free_dma(unsigned int dmanr)
59-
{
60-
if (dmanr >= PARPORT_PC_MAX_PORTS) {
61-
printk(KERN_WARNING "Trying to free DMA%d\n", dmanr);
62-
return;
63-
}
64-
if (xchg(&sparc_ebus_dmas[dmanr].lock, 0) == 0) {
65-
printk(KERN_WARNING "Trying to free free DMA%d\n", dmanr);
66-
return;
67-
}
68-
}
69-
70-
static inline void enable_dma(unsigned int dmanr)
71-
{
72-
ebus_dma_enable(&sparc_ebus_dmas[dmanr].info, 1);
73-
74-
if (ebus_dma_request(&sparc_ebus_dmas[dmanr].info,
75-
sparc_ebus_dmas[dmanr].addr,
76-
sparc_ebus_dmas[dmanr].count))
77-
BUG();
78-
}
79-
80-
static inline void disable_dma(unsigned int dmanr)
81-
{
82-
ebus_dma_enable(&sparc_ebus_dmas[dmanr].info, 0);
83-
}
84-
85-
static inline void clear_dma_ff(unsigned int dmanr)
86-
{
87-
/* nothing */
88-
}
89-
90-
static inline void set_dma_mode(unsigned int dmanr, char mode)
91-
{
92-
ebus_dma_prepare(&sparc_ebus_dmas[dmanr].info, (mode != DMA_MODE_WRITE));
93-
}
94-
95-
static inline void set_dma_addr(unsigned int dmanr, unsigned int addr)
96-
{
97-
sparc_ebus_dmas[dmanr].addr = addr;
98-
}
99-
100-
static inline void set_dma_count(unsigned int dmanr, unsigned int count)
101-
{
102-
sparc_ebus_dmas[dmanr].count = count;
103-
}
104-
105-
static inline unsigned int get_dma_residue(unsigned int dmanr)
106-
{
107-
return ebus_dma_residue(&sparc_ebus_dmas[dmanr].info);
108-
}
109-
110-
static int ecpp_probe(struct platform_device *op)
111-
{
112-
unsigned long base = op->resource[0].start;
113-
unsigned long config = op->resource[1].start;
114-
unsigned long d_base = op->resource[2].start;
115-
unsigned long d_len;
116-
struct device_node *parent;
117-
struct parport *p;
118-
int slot, err;
119-
120-
parent = op->dev.of_node->parent;
121-
if (of_node_name_eq(parent, "dma")) {
122-
p = parport_pc_probe_port(base, base + 0x400,
123-
op->archdata.irqs[0], PARPORT_DMA_NOFIFO,
124-
op->dev.parent->parent, 0);
125-
if (!p)
126-
return -ENOMEM;
127-
dev_set_drvdata(&op->dev, p);
128-
return 0;
129-
}
130-
131-
for (slot = 0; slot < PARPORT_PC_MAX_PORTS; slot++) {
132-
if (!test_and_set_bit(slot, dma_slot_map))
133-
break;
134-
}
135-
err = -ENODEV;
136-
if (slot >= PARPORT_PC_MAX_PORTS)
137-
goto out_err;
138-
139-
spin_lock_init(&sparc_ebus_dmas[slot].info.lock);
140-
141-
d_len = (op->resource[2].end - d_base) + 1UL;
142-
sparc_ebus_dmas[slot].info.regs =
143-
of_ioremap(&op->resource[2], 0, d_len, "ECPP DMA");
144-
145-
if (!sparc_ebus_dmas[slot].info.regs)
146-
goto out_clear_map;
147-
148-
sparc_ebus_dmas[slot].info.flags = 0;
149-
sparc_ebus_dmas[slot].info.callback = NULL;
150-
sparc_ebus_dmas[slot].info.client_cookie = NULL;
151-
sparc_ebus_dmas[slot].info.irq = 0xdeadbeef;
152-
strcpy(sparc_ebus_dmas[slot].info.name, "parport");
153-
if (ebus_dma_register(&sparc_ebus_dmas[slot].info))
154-
goto out_unmap_regs;
155-
156-
ebus_dma_irq_enable(&sparc_ebus_dmas[slot].info, 1);
157-
158-
/* Configure IRQ to Push Pull, Level Low */
159-
/* Enable ECP, set bit 2 of the CTR first */
160-
outb(0x04, base + 0x02);
161-
ns87303_modify(config, PCR,
162-
PCR_EPP_ENABLE |
163-
PCR_IRQ_ODRAIN,
164-
PCR_ECP_ENABLE |
165-
PCR_ECP_CLK_ENA |
166-
PCR_IRQ_POLAR);
167-
168-
/* CTR bit 5 controls direction of port */
169-
ns87303_modify(config, PTR,
170-
0, PTR_LPT_REG_DIR);
171-
172-
p = parport_pc_probe_port(base, base + 0x400,
173-
op->archdata.irqs[0],
174-
slot,
175-
op->dev.parent,
176-
0);
177-
err = -ENOMEM;
178-
if (!p)
179-
goto out_disable_irq;
180-
181-
dev_set_drvdata(&op->dev, p);
182-
183-
return 0;
184-
185-
out_disable_irq:
186-
ebus_dma_irq_enable(&sparc_ebus_dmas[slot].info, 0);
187-
ebus_dma_unregister(&sparc_ebus_dmas[slot].info);
188-
189-
out_unmap_regs:
190-
of_iounmap(&op->resource[2], sparc_ebus_dmas[slot].info.regs, d_len);
191-
192-
out_clear_map:
193-
clear_bit(slot, dma_slot_map);
194-
195-
out_err:
196-
return err;
197-
}
198-
199-
static int ecpp_remove(struct platform_device *op)
200-
{
201-
struct parport *p = dev_get_drvdata(&op->dev);
202-
int slot = p->dma;
203-
204-
parport_pc_unregister_port(p);
205-
206-
if (slot != PARPORT_DMA_NOFIFO) {
207-
unsigned long d_base = op->resource[2].start;
208-
unsigned long d_len;
209-
210-
d_len = (op->resource[2].end - d_base) + 1UL;
211-
212-
ebus_dma_irq_enable(&sparc_ebus_dmas[slot].info, 0);
213-
ebus_dma_unregister(&sparc_ebus_dmas[slot].info);
214-
of_iounmap(&op->resource[2],
215-
sparc_ebus_dmas[slot].info.regs,
216-
d_len);
217-
clear_bit(slot, dma_slot_map);
218-
}
219-
220-
return 0;
221-
}
222-
223-
static const struct of_device_id ecpp_match[] = {
224-
{
225-
.name = "ecpp",
226-
},
227-
{
228-
.name = "parallel",
229-
.compatible = "ecpp",
230-
},
231-
{
232-
.name = "parallel",
233-
.compatible = "ns87317-ecpp",
234-
},
235-
{
236-
.name = "parallel",
237-
.compatible = "pnpALI,1533,3",
238-
},
239-
{},
240-
};
241-
242-
static struct platform_driver ecpp_driver = {
243-
.driver = {
244-
.name = "ecpp",
245-
.of_match_table = ecpp_match,
246-
},
247-
.probe = ecpp_probe,
248-
.remove = ecpp_remove,
249-
};
250-
251-
static int parport_pc_find_nonpci_ports(int autoirq, int autodma)
252-
{
253-
return platform_driver_register(&ecpp_driver);
254-
}
255-
256-
#endif /* !(_ASM_SPARC64_PARPORT_H */

0 commit comments

Comments
 (0)