Skip to content

Commit 91e9cc7

Browse files
Marc Zyngieroupton
authored andcommitted
KVM: arm64: Honor trap routing for TCR2_EL1
TCR2_EL1 handling is missing the handling of its trap configuration: - HCRX_EL2.TCR2En must be handled in conjunction with HCR_EL2.{TVM,TRVM} - HFG{R,W}TR_EL2.TCR_EL1 does apply to TCR2_EL1 as well Without these two controls being implemented, it is impossible to correctly route TCR2_EL1 traps. Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Oliver Upton <[email protected]>
1 parent 663abf0 commit 91e9cc7

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

arch/arm64/kvm/emulate-nested.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,8 @@ enum cgt_group_id {
7979
CGT_MDCR_E2TB,
8080
CGT_MDCR_TDCC,
8181

82+
CGT_HCRX_TCR2En,
83+
8284
/*
8385
* Anything after this point is a combination of coarse trap
8486
* controls, which must all be evaluated to decide what to do.
@@ -89,6 +91,7 @@ enum cgt_group_id {
8991
CGT_HCR_TTLB_TTLBIS,
9092
CGT_HCR_TTLB_TTLBOS,
9193
CGT_HCR_TVM_TRVM,
94+
CGT_HCR_TVM_TRVM_HCRX_TCR2En,
9295
CGT_HCR_TPU_TICAB,
9396
CGT_HCR_TPU_TOCU,
9497
CGT_HCR_NV1_nNV2_ENSCXT,
@@ -345,6 +348,12 @@ static const struct trap_bits coarse_trap_bits[] = {
345348
.mask = MDCR_EL2_TDCC,
346349
.behaviour = BEHAVE_FORWARD_ANY,
347350
},
351+
[CGT_HCRX_TCR2En] = {
352+
.index = HCRX_EL2,
353+
.value = 0,
354+
.mask = HCRX_EL2_TCR2En,
355+
.behaviour = BEHAVE_FORWARD_ANY,
356+
},
348357
};
349358

350359
#define MCB(id, ...) \
@@ -359,6 +368,8 @@ static const enum cgt_group_id *coarse_control_combo[] = {
359368
MCB(CGT_HCR_TTLB_TTLBIS, CGT_HCR_TTLB, CGT_HCR_TTLBIS),
360369
MCB(CGT_HCR_TTLB_TTLBOS, CGT_HCR_TTLB, CGT_HCR_TTLBOS),
361370
MCB(CGT_HCR_TVM_TRVM, CGT_HCR_TVM, CGT_HCR_TRVM),
371+
MCB(CGT_HCR_TVM_TRVM_HCRX_TCR2En,
372+
CGT_HCR_TVM, CGT_HCR_TRVM, CGT_HCRX_TCR2En),
362373
MCB(CGT_HCR_TPU_TICAB, CGT_HCR_TPU, CGT_HCR_TICAB),
363374
MCB(CGT_HCR_TPU_TOCU, CGT_HCR_TPU, CGT_HCR_TOCU),
364375
MCB(CGT_HCR_NV1_nNV2_ENSCXT, CGT_HCR_NV1_nNV2, CGT_HCR_ENSCXT),
@@ -622,6 +633,7 @@ static const struct encoding_to_trap_config encoding_to_cgt[] __initconst = {
622633
SR_TRAP(SYS_MAIR_EL1, CGT_HCR_TVM_TRVM),
623634
SR_TRAP(SYS_AMAIR_EL1, CGT_HCR_TVM_TRVM),
624635
SR_TRAP(SYS_CONTEXTIDR_EL1, CGT_HCR_TVM_TRVM),
636+
SR_TRAP(SYS_TCR2_EL1, CGT_HCR_TVM_TRVM_HCRX_TCR2En),
625637
SR_TRAP(SYS_DC_ZVA, CGT_HCR_TDZ),
626638
SR_TRAP(SYS_DC_GVA, CGT_HCR_TDZ),
627639
SR_TRAP(SYS_DC_GZVA, CGT_HCR_TDZ),
@@ -1071,6 +1083,7 @@ static const struct encoding_to_trap_config encoding_to_fgt[] __initconst = {
10711083
SR_FGT(SYS_TPIDRRO_EL0, HFGxTR, TPIDRRO_EL0, 1),
10721084
SR_FGT(SYS_TPIDR_EL1, HFGxTR, TPIDR_EL1, 1),
10731085
SR_FGT(SYS_TCR_EL1, HFGxTR, TCR_EL1, 1),
1086+
SR_FGT(SYS_TCR2_EL1, HFGxTR, TCR_EL1, 1),
10741087
SR_FGT(SYS_SCXTNUM_EL0, HFGxTR, SCXTNUM_EL0, 1),
10751088
SR_FGT(SYS_SCXTNUM_EL1, HFGxTR, SCXTNUM_EL1, 1),
10761089
SR_FGT(SYS_SCTLR_EL1, HFGxTR, SCTLR_EL1, 1),

0 commit comments

Comments
 (0)