Skip to content

Commit 923b2e3

Browse files
tammeladavem330
authored andcommitted
net/sched: act_api: move TCA_EXT_WARN_MSG to the correct hierarchy
TCA_EXT_WARN_MSG is currently sitting outside of the expected hierarchy for the tc actions code. It should sit within TCA_ACT_TAB. Fixes: 0349b87 ("sched: add new attr TCA_EXT_WARN_MSG to report tc extact message") Reviewed-by: Jamal Hadi Salim <[email protected]> Signed-off-by: Pedro Tammela <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 724337b commit 923b2e3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

net/sched/act_api.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1596,12 +1596,12 @@ static int tca_get_fill(struct sk_buff *skb, struct tc_action *actions[],
15961596
if (tcf_action_dump(skb, actions, bind, ref, false) < 0)
15971597
goto out_nlmsg_trim;
15981598

1599-
nla_nest_end(skb, nest);
1600-
16011599
if (extack && extack->_msg &&
16021600
nla_put_string(skb, TCA_EXT_WARN_MSG, extack->_msg))
16031601
goto out_nlmsg_trim;
16041602

1603+
nla_nest_end(skb, nest);
1604+
16051605
nlh->nlmsg_len = skb_tail_pointer(skb) - b;
16061606

16071607
return skb->len;

0 commit comments

Comments
 (0)