tools/power turbostat: fix decoding of HWP_STATUS

anttilaakso · lenb · commit 92c25393586a · 2023-03-17T11:36:46.000-04:00
The "excursion to minimum" information is in bit2
in HWP_STATUS MSR. Fix the bitmask used for
decoding the register.

Signed-off-by: Antti Laakso &lt;antti.laakso@intel.com&gt;
Reviewed-by: Artem Bityutskiy &lt;artem.bityutskiy@linux.intel.com&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
@@ -4425,7 +4425,7 @@ int print_hwp(struct thread_data *t, struct core_data *c, struct pkg_data *p)
 
 	fprintf(outf, "cpu%d: MSR_HWP_STATUS: 0x%08llx "
 		"(%sGuaranteed_Perf_Change, %sExcursion_Min)\n",
-		cpu, msr, ((msr) & 0x1) ? "" : "No-", ((msr) & 0x2) ? "" : "No-");
+		cpu, msr, ((msr) & 0x1) ? "" : "No-", ((msr) & 0x4) ? "" : "No-");
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -4425,7 +4425,7 @@ int print_hwp(struct thread_data t, struct core_data c, struct pkg_data *p)`
`4425`	`4425`
`4426`	`4426`	`fprintf(outf, "cpu%d: MSR_HWP_STATUS: 0x%08llx "`
`4427`	`4427`	`"(%sGuaranteed_Perf_Change, %sExcursion_Min)\n",`
`4428`		`- cpu, msr, ((msr) & 0x1) ? "" : "No-", ((msr) & 0x2) ? "" : "No-");`
	`4428`	`+ cpu, msr, ((msr) & 0x1) ? "" : "No-", ((msr) & 0x4) ? "" : "No-");`
`4429`	`4429`
`4430`	`4430`	`return 0;`
`4431`	`4431`	`}`