Skip to content

Commit 936c985

Browse files
wenslinusw
authored andcommitted
dt-bindings: pinctrl: mt8195: Use real world values for drive-strength arguments
The original binding submission for MT8195 pinctrl described the possible drive strength values in micro-amps in its description, but then proceeded to list register values in its device tree binding constraints. However, the macros used with the Mediatek pinctrl bindings directly specify the drive strength in micro-amps, instead of hardware register values. The current driver implementation in Linux does convert the value from micro-amps to hardware register values. This implementation is also used with MT7622 and MT8183, which use real world values in their device trees. Given the above, it was likely an oversight to use the raw register values in the binding. Correct the values in the binding. Also drop the description since the binding combined with its parent, pinctrl/pincfg.yaml, the binding is now self-describing. Fixes: 7f76638 ("dt-bindings: pinctrl: mt8195: add pinctrl file and binding document") Signed-off-by: Chen-Yu Tsai <[email protected]> Acked-by: Rob Herring <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent 379e28b commit 936c985

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,7 @@ patternProperties:
8080
as macros in dt-bindings/pinctrl/<soc>-pinfunc.h directly.
8181
8282
drive-strength:
83-
description: |
84-
It can support some arguments which is from 0 to 7. It can only support
85-
2/4/6/8/10/12/14/16mA in mt8195.
86-
enum: [0, 1, 2, 3, 4, 5, 6, 7]
83+
enum: [2, 4, 6, 8, 10, 12, 14, 16]
8784

8885
bias-pull-down: true
8986

0 commit comments

Comments
 (0)