Skip to content

Commit 93e843f

Browse files
olsajiriacmel
authored andcommitted
perf/ui/gtk: Fix gtk2 build
Ravi Bangoria reported an issue when doing the gtk2 feature detection on Fedora 31, where some types got deprecated: /usr/include/gtk-2.0/gtk/gtktypeutils.h:236:1: error: ‘GTypeDebugFlags’ is deprecated [-Werror=deprecated-declarations] 236 | void gtk_type_init (GTypeDebugFlags debug_flags); Fix this for perf by allowing the compile to pass with deprecated symbols via the -Wno-deprecated-declarations compiler directive. Reported-by: Ravi Bangoria <[email protected]> Signed-off-by: Jiri Olsa <[email protected]> Tested-by: Ravi Bangoria <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Jelle van der Waa <[email protected]> Cc: Michael Petlan <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Peter Zijlstra <[email protected]> Link: http://lore.kernel.org/lkml/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent 604e213 commit 93e843f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tools/build/feature/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ $(OUTPUT)test-libcrypto.bin:
197197
$(BUILD) -lcrypto
198198

199199
$(OUTPUT)test-gtk2.bin:
200-
$(BUILD) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null)
200+
$(BUILD) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) -Wno-deprecated-declarations
201201

202202
$(OUTPUT)test-gtk2-infobar.bin:
203203
$(BUILD) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null)

tools/perf/ui/gtk/Build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
CFLAGS_gtk += -fPIC $(GTK_CFLAGS)
1+
CFLAGS_gtk += -fPIC $(GTK_CFLAGS) -Wno-deprecated-declarations
22

33
gtk-y += browser.o
44
gtk-y += hists.o

0 commit comments

Comments
 (0)