Skip to content

Commit 945bdae

Browse files
roypatsean-jc
authored andcommitted
KVM: selftests: fix unintentional noop test in guest_memfd_test.c
The loop in test_create_guest_memfd_invalid() that is supposed to test that nothing is accepted as a valid flag to KVM_CREATE_GUEST_MEMFD was initializing `flag` as 0 instead of BIT(0). This caused the loop to immediately exit instead of iterating over BIT(0), BIT(1), ... . Fixes: 8a89efd ("KVM: selftests: Add basic selftest for guest_memfd()") Signed-off-by: Patrick Roy <[email protected]> Reviewed-by: James Gowans <[email protected]> Reviewed-by: Muhammad Usama Anjum <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Sean Christopherson <[email protected]>
1 parent 2d0f2a6 commit 945bdae

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/testing/selftests/kvm/guest_memfd_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ static void test_create_guest_memfd_invalid(struct kvm_vm *vm)
134134
size);
135135
}
136136

137-
for (flag = 0; flag; flag <<= 1) {
137+
for (flag = BIT(0); flag; flag <<= 1) {
138138
fd = __vm_create_guest_memfd(vm, page_size, flag);
139139
TEST_ASSERT(fd == -1 && errno == EINVAL,
140140
"guest_memfd() with flag '0x%lx' should fail with EINVAL",

0 commit comments

Comments
 (0)