Skip to content

Commit 94945ad

Browse files
committed
netfilter: conntrack: comparison of unsigned in cthelper confirmation
net/netfilter/nf_conntrack_core.c: In function nf_confirm_cthelper: net/netfilter/nf_conntrack_core.c:2117:15: warning: comparison of unsigned expression in < 0 is always false [-Wtype-limits] 2117 | if (protoff < 0 || (frag_off & htons(~0x7)) != 0) | ^ ipv6_skip_exthdr() returns a signed integer. Reported-by: Colin Ian King <[email protected]> Fixes: 703acd7 ("netfilter: nfnetlink_cthelper: unbreak userspace helper support") Signed-off-by: Pablo Neira Ayuso <[email protected]>
1 parent 46c1e06 commit 94945ad

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/netfilter/nf_conntrack_core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2092,7 +2092,7 @@ static int nf_confirm_cthelper(struct sk_buff *skb, struct nf_conn *ct,
20922092
{
20932093
const struct nf_conntrack_helper *helper;
20942094
const struct nf_conn_help *help;
2095-
unsigned int protoff;
2095+
int protoff;
20962096

20972097
help = nfct_help(ct);
20982098
if (!help)

0 commit comments

Comments
 (0)