Skip to content

Commit 94b38b8

Browse files
Zhikai Zhaialexdeucher
authored andcommitted
drm/amd/display: Add align done check
[WHY] We Double-check link status if training successful, but miss the lane align status. [HOW] Add the lane align status check Cc: Mario Limonciello <[email protected]> Cc: Alex Deucher <[email protected]> Cc: [email protected] Reviewed-by: Wenjing Liu <[email protected]> Acked-by: Aurabindo Pillai <[email protected]> Signed-off-by: Zhikai Zhai <[email protected]> Tested-by: Daniel Wheeler <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 9163616 commit 94b38b8

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -517,6 +517,7 @@ enum link_training_result dp_check_link_loss_status(
517517
{
518518
enum link_training_result status = LINK_TRAINING_SUCCESS;
519519
union lane_status lane_status;
520+
union lane_align_status_updated dpcd_lane_status_updated;
520521
uint8_t dpcd_buf[6] = {0};
521522
uint32_t lane;
522523

@@ -532,10 +533,12 @@ enum link_training_result dp_check_link_loss_status(
532533
* check lanes status
533534
*/
534535
lane_status.raw = dp_get_nibble_at_index(&dpcd_buf[2], lane);
536+
dpcd_lane_status_updated.raw = dpcd_buf[4];
535537

536538
if (!lane_status.bits.CHANNEL_EQ_DONE_0 ||
537539
!lane_status.bits.CR_DONE_0 ||
538-
!lane_status.bits.SYMBOL_LOCKED_0) {
540+
!lane_status.bits.SYMBOL_LOCKED_0 ||
541+
!dp_is_interlane_aligned(dpcd_lane_status_updated)) {
539542
/* if one of the channel equalization, clock
540543
* recovery or symbol lock is dropped
541544
* consider it as (link has been

0 commit comments

Comments
 (0)