Skip to content

Commit 94de486

Browse files
brooniectmarinas
authored andcommitted
kselftest/arm64: Correct misleading comments on fp-stress irritators
The comments in the handlers for the irritator signal in the test threads for fp-stress suggest that the irritator will corrupt the register state observed by the main thread but this is not the case, instead the FPSIMD and SVE irritators (which are the only ones that are implemented) modify the current register state which is expected to be overwritten on return from the handler by the saved register state. Update the comment to reflect what the handler is actually doing. Acked-by: Mark Rutland <[email protected]> Signed-off-by: Mark Brown <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Catalin Marinas <[email protected]>
1 parent 161e992 commit 94de486

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

tools/testing/selftests/arm64/fp/fpsimd-test.S

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,7 @@ function check_vreg
134134
b memcmp
135135
endfunction
136136

137-
// Any SVE register modified here can cause corruption in the main
138-
// thread -- but *only* the registers modified here.
137+
// Modify live register state, the signal return will undo our changes
139138
function irritator_handler
140139
// Increment the irritation signal count (x23):
141140
ldr x0, [x2, #ucontext_regs + 8 * 23]

tools/testing/selftests/arm64/fp/sve-test.S

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,8 +291,7 @@ function check_ffr
291291
#endif
292292
endfunction
293293

294-
// Any SVE register modified here can cause corruption in the main
295-
// thread -- but *only* the registers modified here.
294+
// Modify live register state, the signal return will undo our changes
296295
function irritator_handler
297296
// Increment the irritation signal count (x23):
298297
ldr x0, [x2, #ucontext_regs + 8 * 23]

0 commit comments

Comments
 (0)