Skip to content

Commit 94fed40

Browse files
Colin Ian Kinggregkh
authored andcommitted
staging: vboxsf: fix dereference of pointer dentry before it is null checked
Currently the pointer dentry is being dereferenced before it is being null checked. Fix this by only dereferencing dentry once we know it is not null. Addresses-Coverity: ("Dereference before null check") Fixes: df40286 ("staging: Add VirtualBox guest shared folder (vboxsf) support") Signed-off-by: Colin Ian King <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 32e9f6c commit 94fed40

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/staging/vboxsf/utils.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ int vboxsf_stat_dentry(struct dentry *dentry, struct shfl_fsobjinfo *info)
174174

175175
int vboxsf_inode_revalidate(struct dentry *dentry)
176176
{
177-
struct vboxsf_sbi *sbi = VBOXSF_SBI(dentry->d_sb);
177+
struct vboxsf_sbi *sbi;
178178
struct vboxsf_inode *sf_i;
179179
struct shfl_fsobjinfo info;
180180
struct timespec64 prev_mtime;
@@ -187,6 +187,7 @@ int vboxsf_inode_revalidate(struct dentry *dentry)
187187
inode = d_inode(dentry);
188188
prev_mtime = inode->i_mtime;
189189
sf_i = VBOXSF_I(inode);
190+
sbi = VBOXSF_SBI(dentry->d_sb);
190191
if (!sf_i->force_restat) {
191192
if (time_before(jiffies, dentry->d_time + sbi->o.ttl))
192193
return 0;

0 commit comments

Comments
 (0)