Skip to content

Commit 9566b89

Browse files
Christoph Hellwigweiny2
authored andcommitted
nvdimm: remove nd_integrity_init
nd_integrity_init is only called from a single place. Open code it there, and use IS_ENABLED to remove the need for an extra stub. Signed-off-by: Christoph Hellwig <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Ira Weiny <[email protected]>
1 parent 2c720b4 commit 9566b89

File tree

3 files changed

+8
-35
lines changed

3 files changed

+8
-35
lines changed

drivers/nvdimm/btt.c

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
#include <linux/highmem.h>
77
#include <linux/debugfs.h>
88
#include <linux/blkdev.h>
9+
#include <linux/blk-integrity.h>
910
#include <linux/pagemap.h>
1011
#include <linux/module.h>
1112
#include <linux/device.h>
@@ -1514,10 +1515,13 @@ static int btt_blk_init(struct btt *btt)
15141515
blk_queue_flag_set(QUEUE_FLAG_NONROT, btt->btt_disk->queue);
15151516
blk_queue_flag_set(QUEUE_FLAG_SYNCHRONOUS, btt->btt_disk->queue);
15161517

1517-
if (btt_meta_size(btt)) {
1518-
rc = nd_integrity_init(btt->btt_disk, btt_meta_size(btt));
1519-
if (rc)
1520-
goto out_cleanup_disk;
1518+
if (btt_meta_size(btt) && IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY)) {
1519+
struct blk_integrity bi = {
1520+
.tuple_size = btt_meta_size(btt),
1521+
.tag_size = btt_meta_size(btt),
1522+
};
1523+
blk_integrity_register(btt->btt_disk, &bi);
1524+
blk_queue_max_integrity_segments(btt->btt_disk->queue, 1);
15211525
}
15221526

15231527
set_capacity(btt->btt_disk, btt->nlba * btt->sector_size >> 9);

drivers/nvdimm/core.c

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
#include <linux/export.h>
88
#include <linux/module.h>
99
#include <linux/blkdev.h>
10-
#include <linux/blk-integrity.h>
1110
#include <linux/device.h>
1211
#include <linux/ctype.h>
1312
#include <linux/ndctl.h>
@@ -508,35 +507,6 @@ int nvdimm_bus_add_badrange(struct nvdimm_bus *nvdimm_bus, u64 addr, u64 length)
508507
}
509508
EXPORT_SYMBOL_GPL(nvdimm_bus_add_badrange);
510509

511-
#ifdef CONFIG_BLK_DEV_INTEGRITY
512-
int nd_integrity_init(struct gendisk *disk, unsigned long meta_size)
513-
{
514-
struct blk_integrity bi;
515-
516-
if (meta_size == 0)
517-
return 0;
518-
519-
memset(&bi, 0, sizeof(bi));
520-
521-
bi.tuple_size = meta_size;
522-
bi.tag_size = meta_size;
523-
524-
blk_integrity_register(disk, &bi);
525-
blk_queue_max_integrity_segments(disk->queue, 1);
526-
527-
return 0;
528-
}
529-
EXPORT_SYMBOL(nd_integrity_init);
530-
531-
#else /* CONFIG_BLK_DEV_INTEGRITY */
532-
int nd_integrity_init(struct gendisk *disk, unsigned long meta_size)
533-
{
534-
return 0;
535-
}
536-
EXPORT_SYMBOL(nd_integrity_init);
537-
538-
#endif
539-
540510
static __init int libnvdimm_init(void)
541511
{
542512
int rc;

drivers/nvdimm/nd.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,6 @@ enum nd_async_mode {
489489
ND_ASYNC,
490490
};
491491

492-
int nd_integrity_init(struct gendisk *disk, unsigned long meta_size);
493492
void wait_nvdimm_bus_probe_idle(struct device *dev);
494493
void nd_device_register(struct device *dev);
495494
void nd_device_unregister(struct device *dev, enum nd_async_mode mode);

0 commit comments

Comments
 (0)