Skip to content

Commit 9573446

Browse files
geertumripard
authored andcommitted
Revert "drm: Switch DRM_DISPLAY_HDCP_HELPER to depends on"
This reverts commit 3166e7e, as helper code should always be selected by the driver that needs it, for the convenience of the final user configuring a kernel. The user who configures a kernel should not need to know which helpers are needed for the driver he is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly. Signed-off-by: Geert Uytterhoeven <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/a40e70a0abd3d841c23c107d452a43fdd70ef37a.1713780345.git.geert+renesas@glider.be Signed-off-by: Maxime Ripard <[email protected]>
1 parent d7c128c commit 9573446

File tree

7 files changed

+6
-7
lines changed

7 files changed

+6
-7
lines changed

drivers/gpu/drm/amd/amdgpu/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ config DRM_AMDGPU
44
tristate "AMD GPU"
55
depends on DRM
66
depends on DRM_DISPLAY_DP_HELPER
7-
depends on DRM_DISPLAY_HDCP_HELPER
87
depends on DRM_DISPLAY_HELPER
98
depends on MMU
109
depends on PCI
1110
depends on !UML
1211
select FW_LOADER
1312
select DRM_DISPLAY_HDMI_HELPER
13+
select DRM_DISPLAY_HDCP_HELPER
1414
select DRM_KMS_HELPER
1515
select DRM_SCHED
1616
select DRM_TTM

drivers/gpu/drm/bridge/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,9 @@ config DRM_ITE_IT6505
9494
tristate "ITE IT6505 DisplayPort bridge"
9595
depends on DRM_DISPLAY_DP_AUX_BUS
9696
depends on DRM_DISPLAY_DP_HELPER
97-
depends on DRM_DISPLAY_HDCP_HELPER
9897
depends on DRM_DISPLAY_HELPER
9998
depends on OF
99+
select DRM_DISPLAY_HDCP_HELPER
100100
select DRM_KMS_HELPER
101101
select EXTCON
102102
select CRYPTO

drivers/gpu/drm/bridge/analogix/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ config DRM_ANALOGIX_ANX7625
3535
depends on DRM
3636
depends on DRM_DISPLAY_DP_AUX_BUS
3737
depends on DRM_DISPLAY_DP_HELPER
38-
depends on DRM_DISPLAY_HDCP_HELPER
3938
depends on DRM_DISPLAY_HELPER
4039
depends on OF
40+
select DRM_DISPLAY_HDCP_HELPER
4141
select DRM_MIPI_DSI
4242
help
4343
ANX7625 is an ultra-low power 4K mobile HD transmitter

drivers/gpu/drm/bridge/cadence/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ endif
2424
config DRM_CDNS_MHDP8546
2525
tristate "Cadence DPI/DP bridge"
2626
depends on DRM_DISPLAY_DP_HELPER
27-
depends on DRM_DISPLAY_HDCP_HELPER
2827
depends on DRM_DISPLAY_HELPER
2928
depends on OF
29+
select DRM_DISPLAY_HDCP_HELPER
3030
select DRM_KMS_HELPER
3131
select DRM_PANEL_BRIDGE
3232
help

drivers/gpu/drm/display/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ config DRM_DISPLAY_DP_TUNNEL_STATE_DEBUG
6767
config DRM_DISPLAY_HDCP_HELPER
6868
bool "DRM HDCD Helpers"
6969
depends on DRM_DISPLAY_HELPER
70-
default y
7170
help
7271
DRM display helpers for HDCP.
7372

drivers/gpu/drm/i915/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ config DRM_I915
33
tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics"
44
depends on DRM
55
depends on DRM_DISPLAY_DP_HELPER
6-
depends on DRM_DISPLAY_HDCP_HELPER
76
depends on DRM_DISPLAY_HELPER
87
depends on X86 && PCI
98
depends on !PREEMPT_RT
@@ -13,6 +12,7 @@ config DRM_I915
1312
# the shmem_readpage() which depends upon tmpfs
1413
select SHMEM
1514
select TMPFS
15+
select DRM_DISPLAY_HDCP_HELPER
1616
select DRM_DISPLAY_HDMI_HELPER
1717
select DRM_KMS_HELPER
1818
select DRM_PANEL

drivers/gpu/drm/xe/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ config DRM_XE
44
depends on (m || (y && KUNIT=y))
55
depends on DRM
66
depends on DRM_DISPLAY_DP_HELPER
7-
depends on DRM_DISPLAY_HDCP_HELPER
87
depends on DRM_DISPLAY_HELPER
98
depends on MMU
109
depends on PCI
@@ -19,6 +18,7 @@ config DRM_XE
1918
select DRM_KUNIT_TEST_HELPERS if DRM_XE_KUNIT_TEST != n
2019
select DRM_PANEL
2120
select DRM_SUBALLOC_HELPER
21+
select DRM_DISPLAY_HDCP_HELPER
2222
select DRM_DISPLAY_HDMI_HELPER
2323
select DRM_MIPI_DSI
2424
select RELAY

0 commit comments

Comments
 (0)