Skip to content

Commit 95bebcb

Browse files
Mani-Sadhasivamkwilczynski
authored andcommitted
PCI: qcom-ep: Reword the error message for receiving unknown global IRQ event
Current error message just prints the contents of PARF_INT_ALL_STATUS register as if like the IRQ event number. It could mislead the users. Reword it to make it clear that the error message is actually showing the interrupt status register to help debug spurious IRQ events. While at it, let's also switch over to dev_WARN_ONCE() so that any IRQ storm won't flood the kernel log buffer. Link: https://lore.kernel.org/linux-pci/[email protected] Signed-off-by: Manivannan Sadhasivam <[email protected]> Signed-off-by: Krzysztof Wilczyński <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]>
1 parent 3858e8a commit 95bebcb

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/pci/controller/dwc/pcie-qcom-ep.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -679,7 +679,8 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data)
679679
dw_pcie_ep_linkup(&pci->ep);
680680
pcie_ep->link_status = QCOM_PCIE_EP_LINK_UP;
681681
} else {
682-
dev_err(dev, "Received unknown event: %d\n", status);
682+
dev_WARN_ONCE(dev, 1, "Received unknown event. INT_STATUS: 0x%08x\n",
683+
status);
683684
}
684685

685686
return IRQ_HANDLED;

0 commit comments

Comments
 (0)