Skip to content

Commit 95bf25b

Browse files
committed
drm/udl: Add ARGB8888 as a format
Even though the UDL driver converts to RGB565 internally (see pixel32_to_be16() in udl_transfer.c), it advertises XRGB8888 for compatibility. Let's add ARGB8888 to that list. This makes UDL devices work on ChromeOS again after commit c91acda ("drm/gem: Check for valid formats"). Prior to that commit things were "working" because we'd silently treat the ARGB8888 that ChromeOS wanted as XRGB8888. Fixes: c91acda ("drm/gem: Check for valid formats") Reviewed-by: Dmitry Baryshkov <[email protected]> Signed-off-by: Douglas Anderson <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/20240227141928.1.I24ac8d51544e4624b7e9d438d95880c4283e611b@changeid
1 parent daf8739 commit 95bf25b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/gpu/drm/udl/udl_modeset.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,7 @@ static int udl_handle_damage(struct drm_framebuffer *fb,
253253
static const uint32_t udl_primary_plane_formats[] = {
254254
DRM_FORMAT_RGB565,
255255
DRM_FORMAT_XRGB8888,
256+
DRM_FORMAT_ARGB8888,
256257
};
257258

258259
static const uint64_t udl_primary_plane_fmtmods[] = {

0 commit comments

Comments
 (0)